-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jans-auth-server): Improve DCR / SSA validation for Dynamic Client Registration #2980
Comments
@yuriyz - Please notify me after this is implemented for documentation |
@maduvena sure |
@nynymike proposals:
2.a join for arrays
2.b if single value is use, e.g.
|
I had not considered that a client might present multiple software_statements during DCR. I think its more common that an OP might trust more then one SSA issuer, but I don't think a developer presenting more then one SSA would be common. For simplicity right now, maybe we should not allow it. Client scopes can always be appended after DCR. |
Maybe you are right, it's always possible to construct SSA_sum = SSA1 + SSA2 with exact desired values. So ignore it. |
Currently, there are four options for software statement validation
softwareStatementValidationClaimName
configuration property.softwareStatementValidationClaimName
configuration property.Note: 2-4 should all be deprecated--we should print a note to the logs if these are configured by the admin. They don't convey any trust. We should add another value:
builtin
: which passes the JWT to Auth Server for validation and client provisioning.There is another claim that controls how the dynamic client registration ("DCR") JWT is validated:
While we should maintain this functionality for backwards compatibility with open banking implementations, we can define a more elegant solution for the future.
I propose making one Auth Server property that uses a JSON object to define which issuers are trusted for both DCR and Software Statement validation. What if it looks something like this:
ssa
ordcr
https://examle.com/.well-known/openid-configuration
ssa_jwks_endpoint
One of
jwks
,jwks_uri
orissuers
orconfiguration_endpoint
is requiredThis JSON object will be used during dynamic client registration--whether it should be allowed at all, or especially what scopes should be assigned to the client. Other claims should also be used if they are allowed. For example, perhaps the software statement passes the
software_id
claim. If it's allowed for that SSA issuer, it should be populated automatically via DCR.The text was updated successfully, but these errors were encountered: