Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(agama): relax check of existing flows when transpiling #3121

Closed
jgomer2001 opened this issue Nov 30, 2022 · 0 comments · Fixed by #3123
Closed

chore(agama): relax check of existing flows when transpiling #3121

jgomer2001 opened this issue Nov 30, 2022 · 0 comments · Fixed by #3123
Assignees
@jgomer2001
Labels
comp-agama Touching folder /agama kind-dependencies Pull requests that update a dependency file

Comments

@jgomer2001
Copy link
Contributor

Currently the transpiler checks the Trigger instructions so only existing (registered) flows can be called. This does not align well with the dynamic nature of the language and adds complexity to ADS projects deployment. Also this check cannot be applied when the flow to call is derived from an expression (prepending with $ sign).
@jgomer2001 jgomer2001 self-assigned this Nov 30, 2022
@jgomer2001 jgomer2001 mentioned this issue Nov 30, 2022
Closed
@mo-auto mo-auto added comp-agama Touching folder /agama kind-dependencies Pull requests that update a dependency file labels Nov 30, 2022
jgomer2001 added a commit that referenced this issue Nov 30, 2022
@jgomer2001
chore: remove check of existing flows #3121
63de817
@jgomer2001 jgomer2001 mentioned this issue Nov 30, 2022
Merged
yurem pushed a commit that referenced this issue Nov 30, 2022
@jgomer2001
chore: remove check of existing flows #3121 (#3123)
d4c63d7
@jgomer2001 jgomer2001 changed the title chore(agama): relax check of existing flows when transpiler chore(agama): relax check of existing flows when transpiling Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgomer2001 jgomer2001

Labels
comp-agama Touching folder /agama kind-dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(agama): remove check of existing flows JanssenProject/jans
2 participants
@jgomer2001 @mo-auto