fix: missing fields when creating OIDC clients

[moabu]

When creating a new OIDC client, following fields are not considered (the newly created client does not have the attributes set when loading it):

• displayName
• claims

Request:

{
  "inum": "1201.d52300ed-8193-510e-b31d-5829f4af346e",
  "displayName": "test-client",
  "redirectUris": [
    "https://moabu-21f13b7c-9069-ad58-5685-852e6d236020.gluu.info/.well-known/scim-configuration"
  ],
  "claims": [
    "sub"
  ],
  "baseDn": "inum=1201.d52300ed-8193-510e-b31d-5829f4af346e,ou=clients,o=jans"
}

Response:

{
  "dn": "inum=1201.d52300ed-8193-510e-b31d-5829f4af346e,ou=clients,o=jans",
  "deletable": false,
  "clientSecret": "4691e5f8-9e31-40e8-8ebe-f3e620584b1a",
  "frontChannelLogoutSessionRequired": false,
  "redirectUris": [
    "https://moabu-21f13b7c-9069-ad58-5685-852e6d236020.gluu.info/.well-known/scim-configuration"
  ],
  "grantTypes": [],
  "applicationType": "web",
  "clientNameLocalized": {},
  "logoUriLocalized": {},
  "clientUriLocalized": {},
  "policyUriLocalized": {},
  "tosUriLocalized": {},
  "subjectType": "public",
  "tokenEndpointAuthMethod": "client_secret_basic",
  "trustedClient": false,
  "persistClientAuthorizations": false,
  "includeClaimsInIdToken": false,
  "customAttributes": [
    {
      "name": "displayNameLocalized",
      "multiValued": true,
      "values": [
        "{}"
      ],
      "displayValue": "{}",
      "value": "{}"
    },
    {
      "name": "jansClntURILocalized",
      "multiValued": true,
      "values": [
        "{}"
      ],
      "displayValue": "{}",
      "value": "{}"
    },
    {
      "name": "jansLogoURILocalized",
      "multiValued": true,
      "values": [
        "{}"
      ],
      "displayValue": "{}",
      "value": "{}"
    },
    {
      "name": "jansPolicyURILocalized",
      "multiValued": true,
      "values": [
        "{}"
      ],
      "displayValue": "{}",
      "value": "{}"
    },
    {
      "name": "jansTosURILocalized",
      "multiValued": true,
      "values": [
        "{}"
      ],
      "displayValue": "{}",
      "value": "{}"
    }
  ],
  "rptAsJwt": false,
  "accessTokenAsJwt": false,
  "disabled": false,
  "attributes": {
    "runIntrospectionScriptBeforeJwtCreation": false,
    "keepClientAuthorizationAfterExpiration": false,
    "allowSpontaneousScopes": false,
    "backchannelLogoutSessionRequired": false,
    "parLifetime": 600,
    "requirePar": false,
    "jansDefaultPromptLogin": false,
    "minimumAcrLevel": -1
  },
  "authenticationMethod": "client_secret_basic",
  "baseDn": "inum=1201.d52300ed-8193-510e-b31d-5829f4af346e,ou=clients,o=jans",
  "inum": "1201.d52300ed-8193-510e-b31d-5829f4af346e"
}

[pujavs]

@moabu, following is the analysis and testing

• displayName is orm attribute name(@AttributeName), please use object property clientName to set the value.
  https://github.com/JanssenProject/jans/blob/main/jans-auth-server/common/src/main/java/io/jans/as/common/model/registration/Client.java#L83
  @AttributeName(name = "displayName") private String clientName;
• claims - value passed needs to be valid attribute name in DB. Based on the value passed its DN is fetched and stored as claims while persisting. If claim is not valid then its not set

Testing with correct values:

Please let me know in-case of any concern.

[moabu]

Thanks @pujavs for clarifying . I think we can close this . I'll reopen if needed .

[pujavs]

@moabu, implemented enhancement to be able to provide claims as Dn as well as name while creation and update
Though in DB, claimDN will always be persisted, but the caller will get the claims in the format sent in request.
Also validation added to check and throw error in-case the claim is invalid.
PR 3413

Testing:
OpenId_Client_Claim.zip