Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config-api): client claim enhancement, manual spec removed #3413

Merged
merged 10 commits into from
Dec 26, 2022
Merged

feat(config-api): client claim enhancement, manual spec removed #3413

merged 10 commits into from
Dec 26, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Dec 26, 2022 •
edited
Loading

Prepare

Description

Enhancement:

  1. OpenID: enhancement to be able to provide claims as Dn as well as claim name while creation and update
  2. Swagger spec:
    - manual spec removed
    - user management patch content type rectified

Target issue

closes #3213 #3414

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Dec 26, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 26, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Dec 26, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pujavs pujavs mentioned this pull request Dec 26, 2022
Closed
@yuriyz yuriyz merged commit bd2cdf8 into main Dec 26, 2022
@yuriyz yuriyz deleted the jans-config-fix branch December 26, 2022 10:28
@pujavs pujavs mentioned this pull request Dec 26, 2022
Closed
This was referenced Jan 9, 2023
Merged
Merged
@mo-auto mo-auto mentioned this pull request Jan 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@devrimyatar devrimyatar Awaiting requested review from devrimyatar devrimyatar is a code owner

@smansoft smansoft Awaiting requested review from smansoft

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: missing fields when creating OIDC clients
3 participants
@pujavs @yuriyz @mo-auto