Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-auth-server): end session - if id_token is expired but signature is correct, we should make attempt to look up session by "sid" claim #3231

Closed
2 tasks
yuriyz opened this issue Dec 6, 2022 · 0 comments · Fixed by #3291
Closed
2 tasks

feat(jans-auth-server): end session - if id_token is expired but signature is correct, we should make attempt to look up session by "sid" claim #3231

yuriyz opened this issue Dec 6, 2022 · 0 comments · Fixed by #3291
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request
Milestone
1.0.6

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Dec 6, 2022

Description

end session - if id_token is expired but signature is correct, we should make attempt to look up session by "sid" claim

Test cases and code coverage

  • Write unit test to cover added/changed code
  • Update integration tests to cover added/changed code

oxauth related ticket: GluuFederation/oxAuth#1759
@yuriyz yuriyz self-assigned this Dec 6, 2022
@yuriyz yuriyz added this to the 1.0.6 milestone Dec 6, 2022
@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Dec 6, 2022
yuriyz added a commit that referenced this issue Dec 9, 2022
@yuriyz
feat(jans-auth-server): end session - if id_token is expired but sign…
5dfa61e 
…ature is correct, we should make attempt to look up session by "sid" claim #3231
@yuriyz yuriyz mentioned this issue Dec 12, 2022
Merged
yuriyz added a commit that referenced this issue Dec 12, 2022
@yuriyz
feat(jans-auth-server): end session - if id_token is expired but sign…
cd11750 
…ature is correct, we should make attempt to look up session by "sid" claim #3231 (#3291)

* feat(jans-auth-server): end session - if id_token is expired but signature is correct, we should make attempt to look up session by "sid" claim #3231

* fix(jans-auth-server): sonar complains
@mo-auto3 mo-auto3 mentioned this issue Jan 9, 2023
Merged
@mo-auto mo-auto mentioned this issue Jan 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.0.6
2 participants
@yuriyz @mo-auto