-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: update both enc and sign algorithms on the server #326
Comments
@shmorri This issue has this PR: https://github.com/JanssenProject/jans-auth-server/pull/210 and some additional branches (without PRs yet): https://github.com/JanssenProject/jans-auth-server/tree/sergey_010 Thanks. |
* feat: extending crypto support, sub pr4; #142; * feat: extending crypto support, sub pr4, fixes; #142/#326; * feat: extending crypto support, sub pr4, eddsa_signer has been added; #142/#326; * fix: jans-auth-server: extending crypto support, sub pr4; fixes; #142/#326; * fix: jans-auth-server: extending crypto support, sub pr4; fixes; #142/#326; * feat: jans-auth-server: temp commit for sonar; fixes #365; * feat: jans-auth-server: temp commit for sonar; fixes #365; * feat: jans-auth-server: fix sonar warns; #365; * feat: jans-auth-server: temp commit for sonar; fixes #365; * feat: jans-auth-server: temp commit for sonar; fixes #365; * feat: jans-auth-server: temp commit for sonar; fixes #365; * feat: jans-auth-server: temp commit for sonar; fixes #365; * feat: jans-auth-server: temp commit for sonar; fixes #365;
@ossdhaval can you point me to merged PRs ? I see only big PRs which were not merged because of abnormal size and many refactoring changes. We can't merge such PRs. |
@yuriyz Maybe I was wrong in thinking all PRs have been merged. I added this comment 2 months back and now I don't remember what it was based on 😕 Anyway, @smansoft did a lot of work but unfortunately, the PRs were not of reviewable size. I can see that he also attempted to break it down to smaller PRs. Based on my search, the complete work is spread across below PRs: https://github.com/JanssenProject/jans-auth-server/pull/210 - Full work is in this PR I believe. Too bit to review. Do you think we can find a way forward from here? |
383 and 385 are setup changes only. I don't see PRs to AS side for such changes. We can't change setup and declare something is supported if it is not supported. I guess main changes are in that big 210 PR. I'm closing 383 and 385 PRs for now. Also since 210 is not in reviewable state I think we can close this ticket even if it is not done. And open specific ticket for exact algorithm(s) that we think are useful for AS and which must be added. It will keep scope narrow and will not lead to huge PRs. |
@yuriyz Thank you for your actions on these issues. 🤝 About You are the best judge here I believe. Can you please list out algorithms that you think should be our priority? I'll create issues for only those. Once these new issues are in place, I'll close JanssenProject/jans-auth-server#210 |
Describe the issue
Feat: update both enc and sign algorithms on the server
<style type="text/css"></style>The text was updated successfully, but these errors were encountered: