Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow return of custom authz endpoint request parameters to RP in response #344

Closed
martynaslawinska opened this issue Feb 20, 2021 · 1 comment
Assignees
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-auth-server Component affected by issue or PR effort-3 Relative effort required for completion of issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality priority-5 Issue or PR addresses a very minor concern. Not planned for active development. Will not be fixed. triaged Issue or PR is fully triaged

Comments

@martynaslawinska
Copy link

yurem commented on Nov 15, 2018
It's related to Support Custom Params #647
We need to add boolean option near to each custom parameter name in JSON configuration. When this option is true oxAuth should return custom parameter back to RP.

Today we fixed collision between Gluu IDP and passport-saml. Both of them send in state jwt with additional custom parameters. We added workaround. But this new option will help to resolve this issue.

yurem commented on Dec 13, 2018
Also we return AuthZ custom parameters as headers which leads to cleaning them up on redirect. I think we need to return them in response:
oxAuth/Client/src/test/java/org/xdi/oxauth/ws/rs/AuthorizationResponseCustomHeaderTest.java
Line 81 in b33ad60
81 assertTrue(authorizationResponse.getHeaders().containsKey("CustomHeader1"));

@ghost ghost assigned yurem Dec 27, 2021
@ghost ghost unassigned yurem Jan 10, 2022
@ossdhaval ossdhaval transferred this issue from another repository Jan 13, 2022
@ossdhaval ossdhaval added comp-jans-auth-server Component affected by issue or PR effort-3 Relative effort required for completion of issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality priority-5 Issue or PR addresses a very minor concern. Not planned for active development. Will not be fixed. ready-for-triage Issue or PR has sufficient details and it is ready for triage review labels Jan 13, 2022
moabu pushed a commit that referenced this issue Jan 13, 2022
chore: remove casa script (it's not part of Jans Server)
moabu pushed a commit that referenced this issue Jan 13, 2022
chore: remove casa script (it's not part of Jans Server)
@nynymike nynymike changed the title Allow returning custom parameters to RP Allow return of custom authz endpoint request parameters to RP in response Jan 18, 2022
@qbert2k qbert2k added triaged Issue or PR is fully triaged and removed ready-for-triage Issue or PR has sufficient details and it is ready for triage review labels Feb 3, 2022
@qbert2k
Copy link
Contributor

qbert2k commented Feb 3, 2022

A new boolean param was added to config. In the list of allowed custom parameter we can set returnInResponse to true to return it back to the RP. If it is set to false it will not be returned but will still be stored in session attributes.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-auth-server Component affected by issue or PR effort-3 Relative effort required for completion of issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality priority-5 Issue or PR addresses a very minor concern. Not planned for active development. Will not be fixed. triaged Issue or PR is fully triaged
Projects
None yet
Development

No branches or pull requests

4 participants