Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agama): avoid variables start with java in transpiled code #3533

Closed
jgomer2001 opened this issue Jan 7, 2023 · 0 comments · Fixed by #3534
Closed

fix(agama): avoid variables start with java in transpiled code #3533

jgomer2001 opened this issue Jan 7, 2023 · 0 comments · Fixed by #3534
Assignees
@jgomer2001
Labels
comp-agama Touching folder /agama kind-bug Issue or PR is a bug in existing functionality

Comments

@jgomer2001
Copy link
Contributor

jgomer2001 commented Jan 7, 2023 •
edited
Loading

This will prevent rhino engine to interpret a variable named java in Agama code as a package reference
@jgomer2001 jgomer2001 self-assigned this Jan 7, 2023
@mo-auto mo-auto added comp-agama Touching folder /agama kind-bug Issue or PR is a bug in existing functionality labels Jan 7, 2023
jgomer2001 added a commit that referenced this issue Jan 7, 2023
@jgomer2001
fix: add 'java' to the list of restricted variable names #3533
0a6ece4
@jgomer2001 jgomer2001 mentioned this issue Jan 7, 2023
Merged
yuriyz pushed a commit that referenced this issue Jan 8, 2023
@jgomer2001
fix: add 'java' to the list of restricted variable names #3533 (#3534)
a970d88
@mo-auto mo-auto mentioned this issue Jan 9, 2023
Merged
@mo-auto3 mo-auto3 mentioned this issue Jan 9, 2023
Merged
@mo-auto mo-auto mentioned this issue Jan 9, 2023
Merged
@mo-auto mo-auto mentioned this issue Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgomer2001 jgomer2001

Labels
comp-agama Touching folder /agama kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add 'java' to the list of restricted variable names JanssenProject/jans
2 participants
@jgomer2001 @mo-auto