Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-auth-server): add flexible date formatter handler to AS (required by certification tools) #3600

Closed
2 tasks
yuriyz opened this issue Jan 11, 2023 · 3 comments · Fixed by #3601 or #3605
Closed
2 tasks

feat(jans-auth-server): add flexible date formatter handler to AS (required by certification tools) #3600

yuriyz opened this issue Jan 11, 2023 · 3 comments · Fixed by #3601 or #3605
Assignees
@yuriyz
Labels
certification OpenID Certification comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request
Milestone
1.0.7

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Jan 11, 2023

Description

feat(jans-auth-server): add flexible date formatter handler to AS (needed by certification)

We have different places in AS where date is formatted in one way while certification tools may expect another format (depending on tool). We have to provide flexible way to return dates in different formats.

Test cases and code coverage

  • Write unit test to cover added/changed code
  • Update integration tests to cover added/changed code
@yuriyz yuriyz added comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Jan 11, 2023
@yuriyz yuriyz added this to the 1.0.7 milestone Jan 11, 2023
@yuriyz yuriyz self-assigned this Jan 11, 2023
yuriyz added a commit that referenced this issue Jan 11, 2023
@yuriyz
feat(jans-auth-server): added flexible date formatter handler to AS (…
9367aaf 
…required by certification tools) #3600
@yuriyz yuriyz mentioned this issue Jan 11, 2023
Merged
3 tasks
yuriyz added a commit that referenced this issue Jan 11, 2023
@yuriyz
feat(jans-auth-server): added flexible date formatter handler to AS (…
f646d73 
…required by certification tools) #3600 (#3601)
@Milton-Ch Milton-Ch mentioned this issue Jan 12, 2023
Merged
@Milton-Ch
Copy link
Contributor

@yuriyz I checked this new feature, but it only works for /userinfo endpoint.
I made an extension to make it work on /authorize endpoint.

@yuriyz
Copy link
Contributor Author

yuriyz commented Jan 12, 2023

@Milton-Ch right, we should use this generic service in places where we need it to pass certification and where we need custom formatter. Approved and merged.

@Milton-Ch Milton-Ch added the certification OpenID Certification label Feb 10, 2023
@Milton-Ch
Copy link
Contributor

@yuriyz @nynymike
This birthdate formatting fix must be taken to oxAuth.
I get the same error that I got in Jans.

image

@mo-auto mo-auto mentioned this issue Feb 22, 2023
Merged
This was referenced Feb 22, 2023
Merged
Merged
@mo-auto mo-auto mentioned this issue Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
certification OpenID Certification comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.0.7
2 participants
@yuriyz @Milton-Ch