Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-cli-tui): retreive all scopes rather than setting limit for clients scope list #4034

Closed
devrimyatar opened this issue Mar 2, 2023 · 0 comments · Fixed by #4527
Closed

fix(jans-cli-tui): retreive all scopes rather than setting limit for clients scope list #4034

devrimyatar opened this issue Mar 2, 2023 · 0 comments · Fixed by #4527
Assignees
@devrimyatar @moabu @AbdelwahabAdam
Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Milestone
1.0.12

Comments

@devrimyatar
Copy link
Contributor

Describe the bug
When you try to add scope for client, it uses list of scopes retreived in

https://github.com/JanssenProject/jans/blob/jans-cli-tui-dev-11/jans-cli-tui/cli_tui/plugins/010_auth_server/main.py#L101-L108

Here, limit was set to 200 (max), if there are more than 200 scopes, they won't be retreived. Modify this part by looping so that it retreives 50 scopes each time untill all scopes retreived.
@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-cli-tui Component affected by issue or PR labels Mar 2, 2023
@moabu moabu modified the milestones: 1.0.9, 1.0.10 Mar 7, 2023
@moabu moabu modified the milestones: 1.0.10, 1.0.11 Mar 16, 2023
@moabu moabu modified the milestones: 1.0.11, 1.0.12 Apr 5, 2023
AbdelwahabAdam added a commit that referenced this issue Apr 7, 2023
@AbdelwahabAdam
jans-cli-tui retreive all scopes rather than setting limit for client…
602ab1a 
…s scope list (ref: #4034)
@AbdelwahabAdam AbdelwahabAdam self-assigned this Apr 7, 2023
@AbdelwahabAdam AbdelwahabAdam mentioned this issue Apr 7, 2023
Merged
2 tasks
yuriyz pushed a commit that referenced this issue Apr 7, 2023
@AbdelwahabAdam
jans-cli-tui: retreive all scopes and clean up (ref: #4034) (ref: #4267)
5c0b586 
* jans-cli-tui retreive all scopes rather than setting limit for clients scope list (ref: #4034)

* jans-cli-tui remove Get (ref: #4267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devrimyatar devrimyatar

@moabu moabu

@AbdelwahabAdam AbdelwahabAdam

Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.0.12
Development

Successfully merging a pull request may close this issue.

Jans cli tui works2 JanssenProject/jans
3 participants
@devrimyatar @moabu @AbdelwahabAdam