-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tui): add support for view/edit agama project's flows configurations #4041
Comments
@jgomer2001 For 1 and 3, is this enough? When you press key d on keyboard, TUI displays deployment in json, you can save by pressing Export button |
yes @devrimyatar a window like that is fine. Of course, We have to show only the "configs" section in this case The idea is the user will see & export the sample configurations to a file, then edit & save them, and finally PUT those. These "real" configurations are not part of the deployment json (only the sample) Also I would like to see the errors (if any) in its own window - not json. That is, show only the string error because this data can be quite long and criptic hence it is hard to interpret it in the middle of a bulky json content. This is a topic for a separate issue though |
* fix(jans-cli-tui): status for saving fido configuration * fix(jans-cli-tui): customObjectClasses is jansPerson for creating user * feat(jans-cli-tui): enhance presentation of agama deployments (ref: #3854) * feat(jans-cli-tui): save default ACR (ref: #4031) * feat(jans-cli-tui): attributes (ref: #4035) * fix(jans-cli-tui): code smell * fix(jans-cli-tui): warning message before deleting attribute * feat(jans-cli-tui): show configuration for projet (ref: #4041) * fix(jans-cli-tui): dropdown changes value with up/down even if not activated * fix(jans-cli-tui): code smell * fix(jans-cli-tui): drop down widget selected value * fix(jans-cli-tui): code smell
closing this one, all agama screens need thorough refactoring |
let's add a "button" for every row in agama projects table labeled "Configurations". Upon clicking on it, show a window offering access to 3 functionalities:
For 1, retrieve the configurations using the
/agama-deployment/configs
GET endpoint passing the project name in thequery stringpath param. This will retrieve a json object. You can either show the contents on the screen or dump the contents to disk and show the output path, or both things... If the retrieved json is empty, ie.{ }
, just show a message like "No configurations defined".For 2, a json object must be supplied. How to input data? I'm not sure (through file upload maybe?). The contents must be sent to same endpoint of 1 via PUT
For 3, the sample configurations are found in the json you already obtained via GET
/agama-deployment
for the project in question. More specifically, in theconfigs
key. If it is missing or has an empty json, show a message like "No sample configurations defined", otherwise, show the contents in the screen or dump them to disk, or both - it's up to you.I'll add a comment to this issue when the endpoints for 1 and 2 are ready. I'm still working on them
The text was updated successfully, but these errors were encountered: