Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat [auth-server]: Device Flow needs configurable acr #4305

Closed
imShakil opened this issue Mar 25, 2023 · 3 comments · Fixed by #4424
Closed

feat [auth-server]: Device Flow needs configurable acr #4305

imShakil opened this issue Mar 25, 2023 · 3 comments · Fixed by #4424
Assignees
@yuriyz @moabu
Labels
comp-jans-tui kind-bug Issue or PR is a bug in existing functionality kind-feature Issue or PR is a new feature request
Milestone
1.0.11

Comments

@imShakil
Copy link
Contributor

imShakil commented Mar 25, 2023 •
edited by nynymike
Loading

We need a way to specify the acr (and potentially other params, like agama_flow=...) for device flow. Otherwise when you enable two acr's, it's unpredictable which one may run. Perhaps we can add two Auth Server configuration JSON properties : device_flow_default_acr and device_flow_extra_authn_params ?
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Mar 25, 2023
@yuriyz
Copy link
Contributor

yuriyz commented Mar 25, 2023

It was already reported and fixed in 1.0.11 #4278

@yuriyz yuriyz closed this as completed Mar 25, 2023
@yuriyz
Copy link
Contributor

yuriyz commented Mar 25, 2023

Re-opening and assinging to @devrimyatar to check whether cli sets default acr correctly.

@yuriyz yuriyz reopened this Mar 25, 2023
@yuriyz yuriyz added this to the 1.0.11 milestone Mar 25, 2023
@yuriyz yuriyz changed the title fix(jans-auth): auto 2fa enabling if once fido2/super_gluu scripts are enabled fix(tui): auto 2fa enabling if once fido2/super_gluu scripts are enabled Mar 25, 2023
@nynymike nynymike changed the title fix(tui): auto 2fa enabling if once fido2/super_gluu scripts are enabled feat [auth-server]: Device Flow needs configurable acr Mar 25, 2023
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Mar 25, 2023
@nynymike nynymike assigned yuriyz and unassigned devrimyatar Mar 25, 2023
@nynymike
Copy link
Contributor

I repaced the original content of this message with the root cause--there is no way in Auth Server to specify the acr for device flow.

yuriyz added a commit that referenced this issue Apr 3, 2023
@yuriyz
feat(jans-auth-server): added configurable acr to Device Flow #4305
355cded
@yuriyz yuriyz mentioned this issue Apr 3, 2023
Merged
2 tasks
yuriyz added a commit that referenced this issue Apr 3, 2023
@yuriyz
feat(jans-auth-server): added configurable acr to Device Flow #4305 (#…
fbd4ede 
…4424)
@yuriyz yuriyz mentioned this issue Apr 3, 2023
Closed
This was referenced Apr 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

@moabu moabu

Labels
comp-jans-tui kind-bug Issue or PR is a bug in existing functionality kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.0.11
Development

Successfully merging a pull request may close this issue.

feat(jans-auth-server): added configurable acr to Device Flow #4305 JanssenProject/jans
6 participants
@yuriyz @nynymike @devrimyatar @imShakil @moabu @mo-auto