Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-auth-server): dynamic registration - assign to client only scopes which are explicitly in request #4426

Closed
yuriyz opened this issue Apr 3, 2023 · 0 comments · Fixed by #4577
Closed

fix(jans-auth-server): dynamic registration - assign to client only scopes which are explicitly in request #4426

yuriyz opened this issue Apr 3, 2023 · 0 comments · Fixed by #4577
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Milestone
1.0.12

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Apr 3, 2023

Description

fix(jans-auth-server): dynamic registration - assign to client scopes which are explicitly in request

That logic comes from oxauth which we have there for years, it works as :

  • if request has scopes -> filter it out based on whether scope is default
  • if request does not have scopes -> assign all default scopes

We have to remove second case.
@yuriyz yuriyz added the comp-jans-auth-server Component affected by issue or PR label Apr 3, 2023
@yuriyz yuriyz added this to the 1.0.11 milestone Apr 3, 2023
@yuriyz yuriyz self-assigned this Apr 3, 2023
@yuriyz yuriyz changed the title fix(jans-auth-server): dynamic registration - assign to client scopes which are explicitly in request fix(jans-auth-server): dynamic registration - assign to client only scopes which are explicitly in request Apr 3, 2023
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Apr 3, 2023
@yuriyz yuriyz mentioned this issue Apr 3, 2023
Closed
@moabu moabu modified the milestones: 1.0.11, 1.0.12 Apr 5, 2023
yuriyz added a commit that referenced this issue Apr 13, 2023
@yuriyz
fix(jans-auth-server): dynamic registration - assign to client only s…
670e2d3 
…copes which are explicitly in request #4426
@yuriyz yuriyz mentioned this issue Apr 13, 2023
Merged
2 tasks
yuriyz added a commit that referenced this issue Apr 13, 2023
@yuriyz
fix(jans-auth-server): dynamic registration - assign to client only s…
0b0e624 
…copes which are explicitly in request #4426 (#4577)
@mo-auto mo-auto mentioned this issue Apr 18, 2023
Merged
@yuriyz yuriyz mentioned this issue Apr 22, 2023
Closed
@mo-auto mo-auto mentioned this issue Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.0.12
3 participants
@yuriyz @moabu @mo-auto