Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-config-api): agama deployment detail endpoint not including all flows IDs #4563

Closed
jgomer2001 opened this issue Apr 12, 2023 · 0 comments · Fixed by #4565 or #4566
Closed

fix(jans-config-api): agama deployment detail endpoint not including all flows IDs #4563

jgomer2001 opened this issue Apr 12, 2023 · 0 comments · Fixed by #4565 or #4566
Assignees
@jgomer2001
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@jgomer2001
Copy link
Contributor

When retrieving a deployment details, the flows without errors are not effectively included in the output. This is a serialization problem (keys with null values ignored by default)
@jgomer2001 jgomer2001 self-assigned this Apr 12, 2023
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Apr 12, 2023
@jgomer2001 jgomer2001 mentioned this issue Apr 12, 2023
Closed
jgomer2001 added a commit that referenced this issue Apr 12, 2023
@jgomer2001
fix: ensure all flows are serialized in deployment details #4563
3bed6c6
jgomer2001 added a commit that referenced this issue Apr 12, 2023
@jgomer2001
docs: minor doc updates #4563
a1c3c97
@jgomer2001 jgomer2001 mentioned this issue Apr 12, 2023
Merged
yurem pushed a commit that referenced this issue Apr 12, 2023
@jgomer2001
fix(jans-config-api): agama deployment detail endpoint not including …
358c494 
…all flows IDs (#4565)

* fix: ensure all flows are serialized in deployment details #4563

* docs: minor doc updates #4563
@jgomer2001 jgomer2001 reopened this Apr 12, 2023
jgomer2001 added a commit that referenced this issue Apr 12, 2023
@jgomer2001
fix: update method wrt previous changes in getDeployment #4563
5898182
@jgomer2001 jgomer2001 mentioned this issue Apr 12, 2023
Merged
yuriyz pushed a commit that referenced this issue Apr 12, 2023
@jgomer2001
fix: update method wrt previous changes in getDeployment #4563 (#4566)
53adff1
@mo-auto mo-auto mentioned this issue Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgomer2001 jgomer2001

Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
2 participants
@jgomer2001 @mo-auto