Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: we got 583 failed tests during move to monorepo. Merged PRs were not checked by tests during 14 days due to broken CI/CD #736

Closed
yuriyz opened this issue Jan 31, 2022 · 1 comment
Closed

BUG: we got 583 failed tests during move to monorepo. Merged PRs were not checked by tests during 14 days due to broken CI/CD #736

yuriyz opened this issue Jan 31, 2022 · 1 comment
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Jan 31, 2022

Describe the bug
BUG: we got 583 failed tests during move to monorepo. Merged PR were not checked by tests due to broken CI/CD.
Overall changed during 14 days were not changes which leads to many broken tests once jenkins was restored back.

Reasons:

  1. JARM merged - NPE, wrong response mode (query.jwt vs form.jwt)
  2. consent off for pairwise and single openid scope -> some tests for this use case still expects form. They must be updated
  3. CIBA - it seems to be side effects of other changes, however it has to be checked

References:
#350
@yuriyz yuriyz self-assigned this Jan 31, 2022
@yuriyz yuriyz added comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jan 31, 2022
@yuriyz yuriyz changed the title BUG: we got 583 failed tests during move to monorepo. Merged PR were not checked by tests due to broken CI/CD BUG: we got 583 failed tests during move to monorepo. Merged PRs were not checked by tests during 14 days due to broken CI/CD Jan 31, 2022
yuriyz added a commit that referenced this issue Jan 31, 2022
@yuriyz
fix(jans-auth-server): if consent is off then check whether response …
294bb22 
…already have code

#736
@yuriyzz yuriyzz mentioned this issue Jan 31, 2022
Merged
yuriyz added a commit that referenced this issue Jan 31, 2022
@yuriyz
fix(jans-auth-server): if consent is off then check whether response …
81ad31b 
…already have access_tokne

#736
@yuriyzz yuriyzz mentioned this issue Jan 31, 2022
Merged
yuriyz added a commit that referenced this issue Jan 31, 2022
@yuriyz
fix(jans-auth-server): covered one more case when consent is off
8b59739 
#736
@yuriyzz yuriyzz mentioned this issue Jan 31, 2022
Merged
yuriyz added a commit that referenced this issue Jan 31, 2022
@yuriyz
fix(jans-auth-server): fixed device authz tests
8a952d7 
#736
@yuriyzz yuriyzz mentioned this issue Jan 31, 2022
Merged
@yuriyz
Copy link
Contributor Author

yuriyz commented Feb 1, 2022

From 583 failures I've fixed all except jarm related. Now we have 6 JARM failures.

For this I've opened separate ticket and assigned to @HemantKMehta
#744

image

@yuriyz yuriyz closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuriyz