Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-auth-server): set public subject identifier per client #800

Merged
merged 4 commits into from
Feb 14, 2022
Merged

feat(jans-auth-server): set public subject identifier per client #800

merged 4 commits into from
Feb 14, 2022

Conversation

qbert2k
Copy link
Contributor

@qbert2k qbert2k commented Feb 10, 2022

yuriyz
yuriyz requested changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@yuriyz yuriyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline commends and correct sonar smells.

...server/client/src/test/java/io/jans/as/client/ws/rs/SetPublicSubjectIdentifierPerClient.java Outdated Show resolved Hide resolved
...server/client/src/test/java/io/jans/as/client/ws/rs/SetPublicSubjectIdentifierPerClient.java Outdated Show resolved Hide resolved
...server/client/src/test/java/io/jans/as/client/ws/rs/SetPublicSubjectIdentifierPerClient.java Outdated Show resolved Hide resolved
...server/server/src/main/java/io/jans/as/server/register/ws/rs/RegisterRestWebServiceImpl.java Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.0% 2.0% Duplication

@yuriyz yuriyz merged commit c303bbc into main Feb 14, 2022
@yuriyz yuriyz deleted the jans-auth-server-set-public-subject-identifier-per-client branch February 14, 2022 08:25
@mo-auto mo-auto mentioned this pull request Feb 14, 2022
Closed
@yuriyz yuriyz mentioned this pull request Feb 14, 2022
Closed
This was referenced Feb 14, 2022
Closed
Closed
@mo-auto mo-auto mentioned this pull request Mar 1, 2022
Merged
This was referenced Mar 1, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@devrimyatar devrimyatar Awaiting requested review from devrimyatar devrimyatar is a code owner

@smansoft smansoft Awaiting requested review from smansoft

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qbert2k @yuriyz