Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support push token update on finish authentication #836

Closed
3 tasks done
maduvena opened this issue Feb 17, 2022 · 0 comments
Closed
3 tasks done

feat: support push token update on finish authentication #836

maduvena opened this issue Feb 17, 2022 · 0 comments
Milestone

Comments

@maduvena
Copy link
Contributor


Description

  • Development target issue
    NA
  • Implementation Details
    Currently oxAuth stores push token and other user device information at the end of enrollment flow. Here is place where it gets DeviceData.

To allow push token update we also need to add parameter to finish authentication flow. To AuthenticateResponse we can add similar to RegisterResponse attribute deviceData property.

Prepare NA

  • [X ] Read contribution guidelines NA
  • Read license information NA

Identified code changes NA

  • [X ] task 1 NA
  • [X ] task 2 NA
  • [X ] task 3 NA

Test cases and code coverage NA

  • [X ] Write unit test to cover added/changed code NA
  • [X ] Update integration tests to cover added/changed code NA

Document the changes NA

  • [X ] task for updating user guides if needed NA
  • task for updating installation and configuration guides if needed NA
  • [X ] task for updating developer documentation if needed NA
  • task for updating technical documentation if needed NA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants