Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: config api interception script #840

Merged
merged 4 commits into from
Feb 17, 2022
Merged

feat: config api interception script #840

merged 4 commits into from
Feb 17, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Feb 17, 2022 •
edited
Loading

@yuriyz, request your review and approval for interception script for additional custom check and authorization
Related JIRA 286 #286
Details: code change in three projects

  1. jans-linux-setup: added: jans-linux-setup\static\extension\config_api\config-api-interception.py
  2. jans-core: new config-api custom script and related changes
  3. jans-config-api: invocation of new custom-script after existing to API protection authorization code.
    There are code improvements in the modified classes as per sonar rules.

@pujavs pujavs requested a review from yuriyz February 17, 2022 14:33
@pujavs pujavs mentioned this pull request Feb 17, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pujavs pujavs mentioned this pull request Feb 17, 2022
Closed
@yuriyz yuriyz merged commit 8e4c688 into main Feb 17, 2022
@yuriyz yuriyz deleted the jans-config-api-286 branch February 17, 2022 16:20
This was referenced Feb 17, 2022
Closed
Closed
@devrimyatar devrimyatar added comp-jans-linux-setup Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality labels Feb 23, 2022
This was referenced Mar 1, 2022
Merged
Merged
This was referenced Mar 1, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@devrimyatar devrimyatar Awaiting requested review from devrimyatar devrimyatar is a code owner

@smansoft smansoft Awaiting requested review from smansoft

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-linux-setup Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pujavs @yuriyz @devrimyatar