Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-auth-server): forbid plain pkce if fapi=true (fapi1-advanced-final-par-plain-pkce-rejected fail) #946

Closed
yuriyz opened this issue Mar 2, 2022 · 2 comments
Closed

feat(jans-auth-server): forbid plain pkce if fapi=true (fapi1-advanced-final-par-plain-pkce-rejected fail) #946

yuriyz opened this issue Mar 2, 2022 · 2 comments
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Mar 2, 2022 •
edited
Loading

Description
feat: forbid plain pkce if fapi=true (fapi1-advanced-final-par-plain-pkce-rejected fail)
@yuriyz yuriyz added kind-enhancement Issue or PR is an enhancement to an existing functionality comp-jans-auth-server Component affected by issue or PR labels Mar 2, 2022
@yuriyz yuriyz self-assigned this Mar 2, 2022
@yuriyz yuriyz changed the title feat: forbit plain pkce if fapi=true (fapi1-advanced-final-par-plain-pkce-rejected fail) feat: forbid plain pkce if fapi=true (fapi1-advanced-final-par-plain-pkce-rejected fail) Mar 2, 2022
@yuriyz yuriyz changed the title feat: forbid plain pkce if fapi=true (fapi1-advanced-final-par-plain-pkce-rejected fail) feat(jans-auth-server): forbid plain pkce if fapi=true (fapi1-advanced-final-par-plain-pkce-rejected fail) Mar 2, 2022
yuriyz added a commit that referenced this issue Mar 2, 2022
@yuriyz
feat(jans-auth-server): forbid plain pkce if fapi=true (fapi1-advance…
21cecb0 
…d-final-par-plain-pkce-rejected fail) #946

#946
@yuriyzz yuriyzz mentioned this issue Mar 2, 2022
Merged
yuriyz added a commit that referenced this issue Mar 3, 2022
@yuriyz
Merge pull request #947 from JanssenProject/jans-auth-server-issue-946
fb41c5a 
feat(jans-auth-server): forbid plain pkce if fapi=true (fapi1-advanced-final-par-plain-pkce-rejected fail) #946
@yuriyz
Copy link
Contributor Author

yuriyz commented Mar 3, 2022

Issue is fixed.
@HemantKMehta can you run fapi test and confirm ?

@yuriyz yuriyz closed this as completed Mar 3, 2022
@HemantKMehta
Copy link
Contributor

Tested and it is working fine.

yuriyz added a commit that referenced this issue Mar 3, 2022
@yuriyz
fix(jans-auth-server): corrected ParValidatorTest #946
04a01fd 
#946
@yuriyzz yuriyzz mentioned this issue Mar 3, 2022
Merged
3 tasks
yuriyz added a commit that referenced this issue Mar 3, 2022
@yuriyz
Merge pull request #965 from JanssenProject/jans-auth-server-issue-946-1
eea33ea 
fix(jans-auth-server): corrected ParValidatorTest #946
@mo-auto mo-auto mentioned this issue Mar 14, 2022
Merged
@mo-auto3 mo-auto3 mentioned this issue Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuriyz @HemantKMehta