Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fido u2f endpoints #978

Closed
jgomer2001 opened this issue Mar 4, 2022 · 1 comment
Closed

Remove fido u2f endpoints #978

jgomer2001 opened this issue Mar 4, 2022 · 1 comment
Assignees
@yurem @devrimyatar @moabu
Labels
comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR needs-triage Issue or PR yet to be triaged. Add more labels or details that will help during triage review.

Comments

@jgomer2001
Copy link
Contributor

jgomer2001 commented Mar 4, 2022 •
edited
Loading

There is no need for u2f endpoints anymore since we already expose FIDO2 functionalities.

Supergluu is not a requirement for Jans, so these endpoints can be safely removed. SG will be migrated to use FIDO2

Additionally, we can skip the u2f and supergluu scripts from the installation process and from jans-linux-setup/jans_setup/static/extension/person_authentication. Remove file U2fExternalAuthenticator.py as well

Likewise, remove u2f directory from jans-auth-server/webapp/auth and u2f.xhtml from jans-auth-server/webapp/auth/casa
@jgomer2001 jgomer2001 added comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR needs-triage Issue or PR yet to be triaged. Add more labels or details that will help during triage review. labels Mar 4, 2022
This was referenced Mar 4, 2022
Open
Closed
yurem added a commit that referenced this issue Mar 7, 2022
@yurem
feat: remove fido u2f endpoints #978
abce628
yurem added a commit that referenced this issue Mar 7, 2022
@yurem
feat: remove fido u2f endpoints #978
6abef87
yurem added a commit that referenced this issue Mar 7, 2022
@yurem
feat: remove fido u2f endpoints #978
bcc733b
This was referenced Mar 7, 2022
Closed
Closed
yurem added a commit that referenced this issue Mar 7, 2022
@yurem
feat: remove fido u2f endpoints #978
e2cad3c
@yurem yurem mentioned this issue Mar 7, 2022
Merged
@yurem
Copy link
Contributor

yurem commented Mar 7, 2022

Removed

@yurem yurem closed this as completed Mar 7, 2022
@devrimyatar devrimyatar mentioned this issue Mar 7, 2022
Merged
devrimyatar referenced this issue Mar 7, 2022
@devrimyatar
fix: jans-linux-setup remove fido authentication scripts from template
bbbaf8a
yurem added a commit that referenced this issue Mar 7, 2022
@yurem
Remove fido u2f (#989)
452ce0f 
* feat: remove fido u2f endpoints #978

* feat: remove fido u2f endpoints #978

* feat: remove fido u2f endpoints #978

* feat: remove fido u2f endpoints #978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurem yurem

@devrimyatar devrimyatar

@moabu moabu

Labels
comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR needs-triage Issue or PR yet to be triaged. Add more labels or details that will help during triage review.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jgomer2001 @yurem @devrimyatar @moabu