Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(jans-auth-server): code_challenge and code_challenge_method are not picked up from request object for PAR #999

Closed
yuriyz opened this issue Mar 8, 2022 · 2 comments
Closed

bug(jans-auth-server): code_challenge and code_challenge_method are not picked up from request object for PAR #999

yuriyz opened this issue Mar 8, 2022 · 2 comments
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality triaged Issue or PR is fully triaged

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Mar 8, 2022

bug: code_challenge and code_challenge_method are not picked up from request object for PAR

FAPI 1 Advanced Final (Generic), which is normal test (non openbanking).

https://www.certification.openid.net/log-detail.html?log=AWMzsQBzJUzYwBR&public=true
@yuriyz yuriyz added kind-bug Issue or PR is a bug in existing functionality comp-jans-auth-server Component affected by issue or PR triaged Issue or PR is fully triaged labels Mar 8, 2022
@yuriyz yuriyz self-assigned this Mar 8, 2022
@yuriyz yuriyz changed the title bug: code_challenge and code_challenge_method are not picked up from request object for PAR bug(jans-auth-server): code_challenge and code_challenge_method are not picked up from request object for PAR Mar 8, 2022
yuriyz added a commit that referenced this issue Mar 10, 2022
@yuriyz
fix(jans-auth-server): validate pkce after extraction data from reque…
29fdfae 
…st object (#999)

#999
@yuriyzz yuriyzz mentioned this issue Mar 10, 2022
Merged
yuriyz added a commit that referenced this issue Mar 10, 2022
@yuriyz
Merge pull request #1009 from JanssenProject/jans-auth-server-issue-999
b73a5fe 
fix(jans-auth-server): validate pkce after extraction data from request object (#999)
@yuriyz
Copy link
Contributor Author

yuriyz commented Mar 10, 2022

@HemantKMehta issue is fixed, please validate

@mo-auto mo-auto mentioned this issue Mar 14, 2022
Merged
@mo-auto3 mo-auto3 mentioned this issue Mar 14, 2022
Merged
@HemantKMehta
Copy link
Contributor

tested it and its working fine.

@mo-auto mo-auto mentioned this issue May 18, 2022
Merged
@mo-auto3 mo-auto3 mentioned this issue May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality triaged Issue or PR is fully triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuriyz @HemantKMehta