feat(helm): Update Helm Chart #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
github-actions
bot
commented
Nov 20, 2020
github-actions
bot
commented
- Update Helm chart
- Auto-generated due to a change in the main repo https://github.com/GluuFederation/cloud-native-edition
github-actions
bot
added
the
kind-enhancement
moabu
pushed a commit
that referenced
this pull request
Jan 12, 2022
…t-4.13.1 Bump junit from 4.13 to 4.13.1
moabu
added a commit
that referenced
this pull request
Jan 13, 2022
* first commit * gitignore * oxEleven Server * oxEleven Client * TestNG config and params * Constants * JWKS Rest Service * Fail tests * Fix Maven build * License * readme * Update README.md * Update README.md * VerifySignature updated Added param Jwks * Added algorithms: none, HS256, HS384, HS512 * mvn compiler version * mvn compiler version * Param names * Expiration Time * Fix Maven compilation errors * Fix Maven compilation errors * Fix Maven compilation errors * Fix Maven Errors * Fix Maven Errors * Jenkins Tests * war file and tomcat conf #1 $CATALINA_HOME/conf/oxeleven-config.json war file is located in: https://ox.gluu.org/maven/org/gluu/oxeleven-server * Jenkins Tests * Jenkins Tests * Updating description * Updating project description * Updating project description * Updating project description * Updating project description * Updating project description * edit oxeleven-config.json #4 Updating project description * Add version release #6 I have added a VERSION file in the root directory. Also you can see the version at https://github.com/GluuFederation/oxEleven/blob/master/pom.xml#L9 * Debug failing tests in Ubuntu #7 * Debug failing tests in Ubuntu #7 * Debug failing tests in Ubuntu #7 * Debug failing tests in Ubuntu #7 * Update README.md * Update componets.xml to conform Seam 2.3.1 * Update .gitignore * Fix Seam and resteasy integration to allow inject Seam objects * Fix web services * Version 2.4.4-SNAPSHOT * Client side method to load private key from JWKS #217 * Version 2.4.5-SNAPSHOT * Clean up to avoid warnings * oxAuth #341 Update KeyGenerator to allow generate keys for oxEleven * Version 3.0.0-SNAPSHOT * Version 3.1.0-SNAPSHOT * Update README.md * oxEleven #13 Need to implement OAuth2 security for endpoints * Update test server to ce-dev3 * README updated oxEleven #13 Need to implement OAuth2 security for endpoints * Update oxeleven-config.json * Migrate from Seam to Weld 3.0 * Update testing data to conform Weld version * Add jetty resources * Add testng dependecy * Fix tests execution * Replace getLocation with getLocationLink * Init BC provider * Add observer to force app initialization * Fux log initialization * Add comment to class which application re-create on each operation * Use Producer to create PKCS11Service instead of creating it on every request * Fix startup issue * Add ApplicationService with producer for PKCS11Service * Remove not required dependencies * Re-add log4j core * Version 3.2.0-SNAPSHOT * Update LICENSE * Use ce-dev4 for testing * Update BC libs * Version 4.0.0 * Use ce-dev5 server * Change org.xdi -> org.gluu oxCore #58 * Upgrade to Jackson 2.x (from current Jackson 1.x) oxAuth #811 * Update resteasy * Use jackson2 reasteasy provider * Remove jaxrs-api library * Update jackson to latest version * Update jackson-databind * Try to resolve bean to xml mapping issue * Fix bean serialization * Fix JSON serialization in verify sign test * Remove unused imports * oxeleven : jackson-databind 2.9.9.1 -> 2.9.9.2 * Update jackson-databind * Branch for version 4.1 * Use gluu core bom * Branch for version 4.2 * Update libs * Branch for version 4.3 * Branch for version 5.0 * Update to Apache 2.0 License * Moved project to janssen based artifacts * org.janssen -> io.jans * Package renaming org.janssen -> io.jans * rename : eleven -> jans-eleven * Rename modules to conform current naming rules * Fix modeul names * Fix license, properties and conform jans project * Use gluu.base to find jans.properties location * Define heal check endpoint * Rename jans Eleven config * Use shorter name for conf file * Use new dev server * Changed version 5.0.0-SNAPSHOT -> 1.0.0-SNAPSHOT * Changed copyright text to Apache 2 license * Update BC libs * Update BC libs * docs(codacy): Add badge * ci(commit-check): Add commit reporter * ci(commit-check): show details in commit * ci(commit-check): check all branches * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci: fix version * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows (#17) Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows (#18) Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * chore: resteasy update * chore: use log4j in client * chore: remove unused impport * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(monorepo): prepare jans-eleven Co-authored-by: Javier Rojas Blum <javier.rojas.blum@gmail.com> Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com> Co-authored-by: William Lowe <willow9886@gmail.com> Co-authored-by: Yuriy Zabrovarnyy <yzabrovarniy@gmail.com> Co-authored-by: Mike Schwartz <mike@gluu.org> Co-authored-by: Sync bot <54212639+mo-auto@users.noreply.github.com> Co-authored-by: Dhaval D <343411+ossdhaval@users.noreply.github.com>
moabu
added a commit
that referenced
this pull request
Jan 13, 2022
* Initial commit * Move Fido2 from oxAuth server * Add empty test files * Update final artifact name * Update README.md * Allow to reuse required services in fido2 server * Fido2 updates and reorganize packages * Allow to configure RP list and credential types in attestation request * Update to conform latest config * U2f to Fido2 migration * Fido to Fido2 enrollment migration oxAuth #1373 * Fido to Fido2 enrollment migration oxAuth #1373 * Disable tests * Disable cleaner becuase it's not support per application splitting * Remove option to disable fido2 endpoints * Store counter in separate attribute * Don't clean up compromised registrations * Allow to reuse persistence models * Fix dependecies * Set creation date and display name more precisely * Fix EC X/Y coord size during U2F -> Fido2 migration * transports can't be converted to a sequence (JS error if there is already an enrollment) #1 * Branch for version 4.3 * Branch for version 5.0 * Add health-check controller to fido2-server * Store issued tokens count metrics #1436 * Turn off metric reported by default if there is no configuration * Exclude jackrabit * Fix dependecy issue * Add missing service * Allow to skip attestation signature check * Update log message when server can't check U2F attestation signature * Rethrow expcetion on U2F attestion enrollment is checkU2fAttestations = true * Improve health check * Sync with 4.2.2 * Changed dependencies from gluu -> janssen * clean up * put back gluu maven repo * Artifacts group rename : org.janssen -> io.jans * Java package rename : org.gluu -> io.jans * Rename artifcatId * Fix fido2 dependecies * Update to conform auth server * Update to conform ORM * Fix license, properties and conform jans project * Fix package name * Fix compilation * Update attribute names * Use jsAppConfiguration OC * Replace js with jans * Replace js with jans * Rename properties * Use gluu.base to find jans.properties location * Rename OC to conform jans * Replace base DN to o=jans * Update configuration load * Use Fido2 configuration * Remove duplicate services * Remove extra /fido2 from patch * Update README.md * Create codeql-analysis.yml * Remove extra fido2 from API endpoints * Add second resteasy initializer for system endpoints * Rename /system to /sys * ci(vulnerability-scan.yml): Add Anchore vulnerability scan Adds vulnerability scan report to GitHub security. * Update import * Switched version 5.0.0-SNAPSHOT -> 1.0.0-SNAPSHOT * Don't stop on unsuccessfull BC installation * Swagger spec for Fido2 * Add ORM SQL dependecy * Clean up * Don't use custom OC if ORM is not ldap * docs(codacy): Add badge * ci(commit-check): Add commit reporter * ci(commit-check): show details in commit * ci(commit-check): check all branches * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci: integrate with JaCoCo and Sonarcloud * feat: add repositories to POM * fix: implement missing method * fix: remove Sonar workflow file After review, it was decided to have a central workflow file. This is approach is more maintainable than having separate workflow file for each repository. Hence, removing individual workflow file from this repo so that common workflow file can take its place. * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * fix: move up Jans maven repo in pom.xml * fix: remove gluu maven repository * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci: fix version * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * feat: Apple's Touch ID as a fido2 device * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows (#15) Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * fix: removed unused code * fix: buildfix * chore: update to conform resteasy 4 * chore: add missing repos * chore: force checks * fix: fix FIdo2 OC name * chore: fix typo in attribute name * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(codeowners): remove unnecessary files * ci(monorepo): prepare jans-fido2 Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com> Co-authored-by: Jose <bonustrack310@gmail.com> Co-authored-by: YuriyZ <yzabrovarniy@gmail.com> Co-authored-by: HemantKMehta <70174684+HemantKMehta@users.noreply.github.com> Co-authored-by: pujavs <pujas.works@gmail.com> Co-authored-by: Sync bot <54212639+mo-auto@users.noreply.github.com> Co-authored-by: ossdhaval <ossdhaval@outlook.com> Co-authored-by: ossdhaval <343411+ossdhaval@users.noreply.github.com> Co-authored-by: Madhumita <madhu@gluu.org>
moabu
pushed a commit
that referenced
this pull request
Jan 13, 2022
moabu
pushed a commit
that referenced
this pull request
Jan 13, 2022
moabu
pushed a commit
that referenced
this pull request
Jan 13, 2022
moabu
pushed a commit
that referenced
this pull request
Jan 13, 2022
Uma API protection code for review - Note key store and password code pending, will check with Arnab how to create a key store
moabu
pushed a commit
that referenced
this pull request
Jan 13, 2022
Create jans-config-api.service file
moabu
pushed a commit
that referenced
this pull request
Jan 13, 2022
moabu
pushed a commit
that referenced
this pull request
Jan 13, 2022
moabu
pushed a commit
that referenced
this pull request
Jan 13, 2022
moabu
added a commit
that referenced
this pull request
Jan 13, 2022
* first commit * gitignore * oxEleven Server * oxEleven Client * TestNG config and params * Constants * JWKS Rest Service * Fail tests * Fix Maven build * License * readme * Update README.md * Update README.md * VerifySignature updated Added param Jwks * Added algorithms: none, HS256, HS384, HS512 * mvn compiler version * mvn compiler version * Param names * Expiration Time * Fix Maven compilation errors * Fix Maven compilation errors * Fix Maven compilation errors * Fix Maven Errors * Fix Maven Errors * Jenkins Tests * war file and tomcat conf #1 $CATALINA_HOME/conf/oxeleven-config.json war file is located in: https://ox.gluu.org/maven/org/gluu/oxeleven-server * Jenkins Tests * Jenkins Tests * Updating description * Updating project description * Updating project description * Updating project description * Updating project description * Updating project description * edit oxeleven-config.json #4 Updating project description * Add version release #6 I have added a VERSION file in the root directory. Also you can see the version at https://github.com/GluuFederation/oxEleven/blob/master/pom.xml#L9 * Debug failing tests in Ubuntu #7 * Debug failing tests in Ubuntu #7 * Debug failing tests in Ubuntu #7 * Debug failing tests in Ubuntu #7 * Update README.md * Update componets.xml to conform Seam 2.3.1 * Update .gitignore * Fix Seam and resteasy integration to allow inject Seam objects * Fix web services * Version 2.4.4-SNAPSHOT * Client side method to load private key from JWKS #217 * Version 2.4.5-SNAPSHOT * Clean up to avoid warnings * oxAuth #341 Update KeyGenerator to allow generate keys for oxEleven * Version 3.0.0-SNAPSHOT * Version 3.1.0-SNAPSHOT * Update README.md * oxEleven #13 Need to implement OAuth2 security for endpoints * Update test server to ce-dev3 * README updated oxEleven #13 Need to implement OAuth2 security for endpoints * Update oxeleven-config.json * Migrate from Seam to Weld 3.0 * Update testing data to conform Weld version * Add jetty resources * Add testng dependecy * Fix tests execution * Replace getLocation with getLocationLink * Init BC provider * Add observer to force app initialization * Fux log initialization * Add comment to class which application re-create on each operation * Use Producer to create PKCS11Service instead of creating it on every request * Fix startup issue * Add ApplicationService with producer for PKCS11Service * Remove not required dependencies * Re-add log4j core * Version 3.2.0-SNAPSHOT * Update LICENSE * Use ce-dev4 for testing * Update BC libs * Version 4.0.0 * Use ce-dev5 server * Change org.xdi -> org.gluu oxCore #58 * Upgrade to Jackson 2.x (from current Jackson 1.x) oxAuth #811 * Update resteasy * Use jackson2 reasteasy provider * Remove jaxrs-api library * Update jackson to latest version * Update jackson-databind * Try to resolve bean to xml mapping issue * Fix bean serialization * Fix JSON serialization in verify sign test * Remove unused imports * oxeleven : jackson-databind 2.9.9.1 -> 2.9.9.2 * Update jackson-databind * Branch for version 4.1 * Use gluu core bom * Branch for version 4.2 * Update libs * Branch for version 4.3 * Branch for version 5.0 * Update to Apache 2.0 License * Moved project to janssen based artifacts * org.janssen -> io.jans * Package renaming org.janssen -> io.jans * rename : eleven -> jans-eleven * Rename modules to conform current naming rules * Fix modeul names * Fix license, properties and conform jans project * Use gluu.base to find jans.properties location * Define heal check endpoint * Rename jans Eleven config * Use shorter name for conf file * Use new dev server * Changed version 5.0.0-SNAPSHOT -> 1.0.0-SNAPSHOT * Changed copyright text to Apache 2 license * Update BC libs * Update BC libs * docs(codacy): Add badge * ci(commit-check): Add commit reporter * ci(commit-check): show details in commit * ci(commit-check): check all branches * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci: fix version * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows (#17) Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows (#18) Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * chore: resteasy update * chore: use log4j in client * chore: remove unused impport * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(monorepo): prepare jans-eleven Co-authored-by: Javier Rojas Blum <javier.rojas.blum@gmail.com> Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com> Co-authored-by: William Lowe <willow9886@gmail.com> Co-authored-by: Yuriy Zabrovarnyy <yzabrovarniy@gmail.com> Co-authored-by: Mike Schwartz <mike@gluu.org> Co-authored-by: Sync bot <54212639+mo-auto@users.noreply.github.com> Co-authored-by: Dhaval D <343411+ossdhaval@users.noreply.github.com>
moabu
added a commit
that referenced
this pull request
Jan 13, 2022
* Initial commit * Move Fido2 from oxAuth server * Add empty test files * Update final artifact name * Update README.md * Allow to reuse required services in fido2 server * Fido2 updates and reorganize packages * Allow to configure RP list and credential types in attestation request * Update to conform latest config * U2f to Fido2 migration * Fido to Fido2 enrollment migration oxAuth #1373 * Fido to Fido2 enrollment migration oxAuth #1373 * Disable tests * Disable cleaner becuase it's not support per application splitting * Remove option to disable fido2 endpoints * Store counter in separate attribute * Don't clean up compromised registrations * Allow to reuse persistence models * Fix dependecies * Set creation date and display name more precisely * Fix EC X/Y coord size during U2F -> Fido2 migration * transports can't be converted to a sequence (JS error if there is already an enrollment) #1 * Branch for version 4.3 * Branch for version 5.0 * Add health-check controller to fido2-server * Store issued tokens count metrics #1436 * Turn off metric reported by default if there is no configuration * Exclude jackrabit * Fix dependecy issue * Add missing service * Allow to skip attestation signature check * Update log message when server can't check U2F attestation signature * Rethrow expcetion on U2F attestion enrollment is checkU2fAttestations = true * Improve health check * Sync with 4.2.2 * Changed dependencies from gluu -> janssen * clean up * put back gluu maven repo * Artifacts group rename : org.janssen -> io.jans * Java package rename : org.gluu -> io.jans * Rename artifcatId * Fix fido2 dependecies * Update to conform auth server * Update to conform ORM * Fix license, properties and conform jans project * Fix package name * Fix compilation * Update attribute names * Use jsAppConfiguration OC * Replace js with jans * Replace js with jans * Rename properties * Use gluu.base to find jans.properties location * Rename OC to conform jans * Replace base DN to o=jans * Update configuration load * Use Fido2 configuration * Remove duplicate services * Remove extra /fido2 from patch * Update README.md * Create codeql-analysis.yml * Remove extra fido2 from API endpoints * Add second resteasy initializer for system endpoints * Rename /system to /sys * ci(vulnerability-scan.yml): Add Anchore vulnerability scan Adds vulnerability scan report to GitHub security. * Update import * Switched version 5.0.0-SNAPSHOT -> 1.0.0-SNAPSHOT * Don't stop on unsuccessfull BC installation * Swagger spec for Fido2 * Add ORM SQL dependecy * Clean up * Don't use custom OC if ORM is not ldap * docs(codacy): Add badge * ci(commit-check): Add commit reporter * ci(commit-check): show details in commit * ci(commit-check): check all branches * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * ci: integrate with JaCoCo and Sonarcloud * feat: add repositories to POM * fix: implement missing method * fix: remove Sonar workflow file After review, it was decided to have a central workflow file. This is approach is more maintainable than having separate workflow file for each repository. Hence, removing individual workflow file from this repo so that common workflow file can take its place. * ci(workflows): sync workflows * ci(workflows): sync workflows * ci(workflows): sync workflows * fix: move up Jans maven repo in pom.xml * fix: remove gluu maven repository * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci: fix version * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * feat: Apple's Touch ID as a fido2 device * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows (#15) Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * fix: removed unused code * fix: buildfix * chore: update to conform resteasy 4 * chore: add missing repos * chore: force checks * fix: fix FIdo2 OC name * chore: fix typo in attribute name * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(workflows): sync central workflows Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci(codeowners): remove unnecessary files * ci(monorepo): prepare jans-fido2 Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com> Co-authored-by: Jose <bonustrack310@gmail.com> Co-authored-by: YuriyZ <yzabrovarniy@gmail.com> Co-authored-by: HemantKMehta <70174684+HemantKMehta@users.noreply.github.com> Co-authored-by: pujavs <pujas.works@gmail.com> Co-authored-by: Sync bot <54212639+mo-auto@users.noreply.github.com> Co-authored-by: ossdhaval <ossdhaval@outlook.com> Co-authored-by: ossdhaval <343411+ossdhaval@users.noreply.github.com> Co-authored-by: Madhumita <madhu@gluu.org>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.