-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config-api): new endpoint for jans service status and file type script enhancement #10014
Conversation
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…9187 Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…script enhancement Signed-off-by: pujavs <pujas.works@gmail.com>
…script enhancement Signed-off-by: pujavs <pujas.works@gmail.com>
DryRun Security SummaryThe pull request covers various updates and improvements to the Jans Config API application, with a focus on the health monitoring and service status reporting functionality, and while the changes do not appear to introduce immediate security vulnerabilities, there are a few areas that should be carefully reviewed and addressed to maintain the overall security of the application. Expand for full summarySummary: The code changes in this pull request cover various updates and improvements to the Jans Config API application, with a focus on the health monitoring and service status reporting functionality. The changes include the addition of new API endpoints, improvements to date and integer data handling, and the introduction of example responses for certain endpoints. From an application security perspective, the changes do not appear to introduce any immediate security vulnerabilities. However, there are a few areas that should be carefully reviewed and addressed to maintain the overall security of the application:
Overall, the changes appear to be focused on improving the functionality and robustness of the Jans Config API application. By addressing the security considerations outlined above, the application's security posture can be further strengthened and the risk of potential vulnerabilities can be reduced. Files Changed:
Code AnalysisWe ran
Riskiness🟢 Risk threshold not exceeded. |
…script enhancement Signed-off-by: pujavs <pujas.works@gmail.com>
…script enhancement Signed-off-by: pujavs <pujas.works@gmail.com>
Quality Gate passed for 'jans-pycloudlib'Issues Measures |
Quality Gate passed for 'jans-linux-setup'Issues Measures |
Quality Gate passed for 'agama parent'Issues Measures |
Quality Gate passed for 'Jans-Keycloak-Link'Issues Measures |
Quality Gate passed for 'SCIM API'Issues Measures |
Quality Gate passed for 'Fido2 API'Issues Measures |
Quality Gate passed for 'jans-config-api-parent'Issues Measures |
…script enhancement (#10014) * fix(config-api): asset mgt endpoint fixes Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset upload mgt ehancement and fido Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset upload mgt ehancement and fido Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset upload mgt ehancement and fido Signed-off-by: pujavs <pujas.works@gmail.com> * fix(config-api): asset upload Signed-off-by: pujavs <pujas.works@gmail.com> * fix(config-api): lock review comments Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): lock code review comments Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): lock master renamed to lock server Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): lock master renamed to lock server Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): lock master renamed to lock server Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): lock master renamed to lock server Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): fido2 delete functionality Signed-off-by: pujavs <pujas.works@gmail.com> * fix(config-api): acr validation Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): doc(config-api): IDP schema attribute descriptions #9187 Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): sync with main Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): uploading assets via API generates 2 entries #9178 Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset mgt, fido and IDP changes Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): fido2 device endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): fido2 endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): fido2 endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): sync with main Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): sync with main Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): sync with main Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): resolved sonar review issues Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): sonar review comment fix Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): swagger spec Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): saml config attribute description Signed-off-by: pujavs <pujas.works@gmail.com> * doc(config-api): added SAML attribute description Signed-off-by: pujavs <pujas.works@gmail.com> * doc(config-api): added SAML attribute description Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): sync with main Signed-off-by: pujavs <pujas.works@gmail.com> * fix(jans-lock): code review comment fix isssue#9305 Signed-off-by: pujavs <pujas.works@gmail.com> * fix(jans-lock): code review comment fix isssue#9305 Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): lock review point Signed-off-by: pujavs <pujas.works@gmail.com> * fix(lock): code review comment Signed-off-by: pujavs <pujas.works@gmail.com> * fix(lock): code review comment Signed-off-by: pujavs <pujas.works@gmail.com> * fix(config-api): sync with main Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): lock endpoint fixes and SAML IDP NPE Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset enhancement Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): implement timer for asset mgt to fetch and deploy assets forconfig-api #9403 Signed-off-by: pujavs <pujas.works@gmail.com> * fix(config-api): scope validation issue #9426 Signed-off-by: pujavs <pujas.works@gmail.com> * fix(config-api): asset delete error fix Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): sysnc with main Signed-off-by: pujavs <pujas.works@gmail.com> * fix(config-ap): lock audit endpoint parameter declaration error#9460 Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): client token functionality Signed-off-by: pujavs <pujas.works@gmail.com> * fix(Config-api): lock audit endpoint path param rectification Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): clint token endpoint - wip Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): clint token endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): client token endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): client token endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): token endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): token endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): token endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session ednpoint wip Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session ednpoint wip Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session and token endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session and fido2 endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * test(config-api): marked session failing test case Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset mgt dir mapping changes wip Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset mgt dir changes Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset mgt changes for dir Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset mgt endpoint -wip Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): asset mgt endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): custom asset mgt wip Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): custom asset mgt Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): custom asset mgt Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session endpoint changes to remove sessionId Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api) session endpoint changes to hide id Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api) session endpoint changes to hide id Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session endpoint mgt Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session enhancement for removing id Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session endpoint changes to remove session id Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session endpoint changes to remove session id Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session endpoint changes to remove session id Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session endpoint changes to remove session id Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): search fieldValuePair enhancement Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): search fieldValuePair enhancement Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session field filter enhancement - wip Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session field search enhancement wip Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session endpoint search enhancemnt Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session endpoint search enhancemnt Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session endpoint search enhancement Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session and token endpoint enhacement Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session and token search enhancement Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): session search changes for session attribute Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): fido2 search endpoint Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): fido2 entry search Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): pagination implemented in fido2, session and token endpoints Signed-off-by: pujavs <pujas.works@gmail.com> * feat(Config-ap): acr enhacement for agama Signed-off-by: pujavs <pujas.works@gmail.com> * feat(Config-ap): made asset error message descriptive Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): token date format changes Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): date time changes for tkken comparison: Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): date time changes for tkken comparison Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): sync with main Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): date check Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): date format enhancement - wip Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): service status endpoint wip Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): new endpoint for jans service status and file type script enhancement Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): new endpoint for jans service status and file type script enhancement Signed-off-by: pujavs <pujas.works@gmail.com> * feat(config-api): new endpoint for jans service status and file type script enhancement Signed-off-by: pujavs <pujas.works@gmail.com> --------- Signed-off-by: pujavs <pujas.works@gmail.com> Co-authored-by: YuriyZ <yzabrovarniy@gmail.com> Former-commit-id: 7c036f5
Prepare
Description
Target issue
closes #9884 #9979
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.