Fix: Use highest level script in case ACR script is not found #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[jans-cli] Kudos, SonarCloud Quality Gate passed!
|
|
[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!
|
|
[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!
|
|
[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed! |
Milton-Ch
force-pushed
the
fix/use-highest-level-script-in-case-acr-script-not-found
branch
from
fc0ae0f
to
9d1d0b5
Compare
|
Successful Jenkins execution: https://jenkins.jans.io/jenkins/job/jans-auth-server/5924/ |
Milton-Ch
requested review from
devrimyatar,
smansoft,
yuriyz,
pujavs,
yurem,
moabu and
iromli
as code owners
yuriyz
previously approved these changes
Mar 22, 2022
moabu
previously approved these changes
Mar 22, 2022
iromli
previously approved these changes
Mar 22, 2022
devrimyatar
previously approved these changes
Mar 23, 2022
…FF to keep existing behavior.
Milton-Ch
dismissed stale reviews from devrimyatar, iromli, moabu, and yuriyz
via
b90f1e1
Milton-Ch
force-pushed
the
fix/use-highest-level-script-in-case-acr-script-not-found
branch
from
9d1d0b5
to
b90f1e1
Compare
yuriyz
approved these changes
Mar 23, 2022
moabu
approved these changes
Mar 23, 2022
devrimyatar
approved these changes
Mar 23, 2022
Milton-Ch
deleted the
fix/use-highest-level-script-in-case-acr-script-not-found
branch
This was referenced May 18, 2022
This was referenced May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Target issue #
Bug: authorization requests without acr_values and with enabled custom authn scripts fail #791
Implementation Details