Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add script for Google login #1141

Merged
merged 5 commits into from
Apr 18, 2022
Merged

feat: add script for Google login #1141

merged 5 commits into from
Apr 18, 2022

Conversation

maduvena
Copy link
Contributor

Prepare


Description

Target issue

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

[jans-client-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

yuriyz
yuriyz previously approved these changes Mar 31, 2022
@yuriyz
Copy link
Contributor

yuriyz commented Mar 31, 2022

I approved it since it looks good but don't we agree to push scripts and person authentication resources to setup?

https://github.com/JanssenProject/jans/tree/main/jans-linux-setup/jans_setup/static/extension/person_authentication
cc @moabu, @jgomer2001 @mbaser

@moabu
Copy link
Member

moabu commented Mar 31, 2022

Yes we agreed on putting it in jans-linux-setup as the central place

@yuriyz
Copy link
Contributor

yuriyz commented Mar 31, 2022

@maduvena please move these resources to setup.

Copy link
Contributor

@jgomer2001 jgomer2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is usage of "ox..." attributes (inexisting in Jans)
There is mention of SMS in the instructions

@maduvena maduvena requested a review from jgomer2001 April 4, 2022 15:32
@maduvena maduvena self-assigned this Apr 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@moabu moabu changed the title feat: Issue #807 feat: add script for Google login Apr 7, 2022
Copy link
Contributor

@devrimyatar devrimyatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part
b0ce3d4#diff-5a1a282adaaec3b71da4b8c588a2e668616106d2f9100c446ec59690f119292cR44-R56

can be modified as follows:

with open(google_creds_file, 'r') as f:
    try:
        data = json.loads(f.read())
        print data
        creds = data["web"]
        print creds
    except:
        print "Google. Initialization. Failed to load creds from file:", google_creds_file
        print "Exception: ", sys.exc_info()[1]

        return False
       ```

@yurem yurem merged commit bac9144 into main Apr 18, 2022
@yurem yurem deleted the issue_807 branch April 18, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants