-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add script for Google login #1141
Conversation
[jans-cli] Kudos, SonarCloud Quality Gate passed! |
[jans-core] Kudos, SonarCloud Quality Gate passed! |
[jans-client-api] Kudos, SonarCloud Quality Gate passed! |
[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I approved it since it looks good but don't we agree to push scripts and person authentication resources to setup? https://github.com/JanssenProject/jans/tree/main/jans-linux-setup/jans_setup/static/extension/person_authentication |
Yes we agreed on putting it in jans-linux-setup as the central place |
@maduvena please move these resources to setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is usage of "ox..." attributes (inexisting in Jans)
There is mention of SMS in the instructions
[jans-linux-setup] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part
b0ce3d4#diff-5a1a282adaaec3b71da4b8c588a2e668616106d2f9100c446ec59690f119292cR44-R56
can be modified as follows:
with open(google_creds_file, 'r') as f:
try:
data = json.loads(f.read())
print data
creds = data["web"]
print creds
except:
print "Google. Initialization. Failed to load creds from file:", google_creds_file
print "Exception: ", sys.exc_info()[1]
return False
```
Prepare
Description
Target issue
Implementation Details
Test and Document the changes