New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1107 #1165

Merged

devrimyatar merged 3 commits into main from issue_1107

Apr 5, 2022

Contributor

maduvena commented Apr 5, 2022

Prepare

Read PR guidelines
Read license information

Description

Target issue

Implementation Details

jansAuthData in jansFido2AuthnEntry table changed to TEXT type because it was too short
added jansCodeChallengeHash column in jansFIDO2AuthnEntry

Test and Document the changes

Static code analysis has been run locally and issues have been fixed
Relevant unit and integration tests have been added/updated
Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

maduvena added 3 commits

April 5, 2022 10:43


          fix: #1107 - not required

cf46672


          fix: Data too long for column #1107

8eb2c70


          fix: #1107 jansCodeChallengeHash missing

65ac184

maduvena requested review from devrimyatar, smansoft and yuriyz as code owners

April 5, 2022 12:57

sonarcloud bot commented Apr 5, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

sonarcloud bot commented Apr 5, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

devrimyatar approved these changes

View reviewed changes

devrimyatar merged commit cfdc70e into main

devrimyatar deleted the issue_1107 branch

April 5, 2022 13:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet