feat: user management patch endpoint #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns-config-api-418
…ns-config-api-418
…ns-config-api-418
…ns-config-api-418
mo-auto
added
comp-jans-cli-tui
mo-auto
added
comp-jans-orm
yuriyz
previously approved these changes
Apr 8, 2022
…ns-config-api-418
moabu
changed the title
|
[jans-cli] Kudos, SonarCloud Quality Gate passed!
|
yuriyz
previously approved these changes
Apr 12, 2022
| private User updateCustomAttributes(User user, List<CustomObjectAttribute> customAttributes) { | ||
| logger.debug("Custom Attributes to update for - user:{}, customAttributes:{} ", user, customAttributes); | ||
|
|
||
| if (customAttributes != null && !customAttributes.isEmpty()) { |
There was a problem hiding this comment.
Lets do early exit where possible.
if (customAttributes==null || customAttributes.isEmpty()) {
return user;
}
|
[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!
|
|
[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!
|
devrimyatar
previously approved these changes
Apr 13, 2022
|
[jans-config-api-parent] SonarCloud Quality Gate failed. |
yuriyz
approved these changes
Apr 13, 2022
devrimyatar
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for user management endpoint
userPasswordRelated issue 418
Impacted modules: