Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add helper to create persistence entry from LDIF file #1262

Merged
merged 7 commits into from
Apr 27, 2022
Merged

feat: add helper to create persistence entry from LDIF file #1262

merged 7 commits into from
Apr 27, 2022

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Apr 26, 2022

Description

Helper methods are added into jans-pycloudlib directly to promote code reuse for internal/external images (i.e. gluufederation/casa) that need to create entry from LDIF file.

Implementation Details

Each persistence client classes has create_from_ldif method that allows importing data from LDIF file into respected persistence (ldap/couchbase/sql/spanner). By providing this method, any additional LDIF files (i.e. for Casa) can be moved from janssenproject/persistence-loader into 3rd-party images.

Test and Document the changes

  • Relevant unit and integration tests have been added/updated

@iromli
feat: add helper to create persistence entry from LDIF file
b38b3a4 
Helper methods are added into jans-pycloudlib directly to promote code
reuse for internal/external images (i.e. gluufederation/casa)
that need to create entry from LDIF file.
@iromli iromli requested a review from moabu as a code owner April 26, 2022 16:53
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

[jans-pycloudlib] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
11.6% 11.6% Duplication

@mo-auto
chore(jans-pycloudlib): updated build (#1263)
a1ce23c 
Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>
moabu
moabu previously approved these changes Apr 27, 2022
View reviewed changes
@moabu moabu merged commit f2e653e into main Apr 27, 2022
@moabu moabu deleted the cn-persistence branch April 27, 2022 05:40
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

[SCIM API] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 34 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mo-auto2 mo-auto2 mentioned this pull request May 18, 2022
Merged
This was referenced May 18, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 18, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
comp-docker-jans-auth-server comp-docker-jans-certmanager comp-docker-jans-client-api comp-docker-jans-config-api comp-docker-jans-configurator comp-docker-jans-fido2 comp-docker-jans-persistence-loader comp-docker-jans-scim comp-jans-pycloudlib kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iromli @moabu @mo-auto