Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jans-cli download yaml files for build #1635

Merged
merged 1 commit into from
Jun 30, 2022
Merged

fix: jans-cli download yaml files for build #1635

merged 1 commit into from
Jun 30, 2022

Conversation

devrimyatar
Copy link
Contributor

In commit ea929c0 , jans-setup copies yaml files from server directories (feat: jans-cli no local yaml files). For that reason, pyz file is missing yaml files and fails. In this PR, setup.py modified so that it downloads yaml files when building.

@mo-auto mo-auto added comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jun 29, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

moabu
moabu approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@moabu moabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern here is that it is hard coded to the main branch. Assuming that there should never be a rebuild for any pyz package or else it might mix bleeding edge with versions. As long as we never rebuild packages this should be fine .

@yuriyz yuriyz merged commit 31b7e49 into main Jun 30, 2022
@yuriyz yuriyz deleted the jans-cli-fix-build branch June 30, 2022 07:53
This was referenced Jul 6, 2022
Merged
Merged
This was referenced Aug 30, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

@yuriyz yuriyz yuriyz approved these changes

Assignees
No one assigned
Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devrimyatar @yuriyz @moabu @mo-auto