Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-config-api): fixed due to couchbase clustter change #1863

Merged
merged 4 commits into from
Jul 25, 2022
Merged

fix(jans-config-api): fixed due to couchbase clustter change #1863

merged 4 commits into from
Jul 25, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Jul 25, 2022 •
edited
Loading

Prepare

Description

Fixed config-api build issue

Target issue

Closes: 1862

Implementation Details

In config-api CouchbaseConfigurationResource DefaultCouchbaseEnvironment became obsolete due to orm changes for clustered environment and hence replaced com.couchbase.client.java.env.DefaultCouchbaseEnvironment with com.couchbase.client.java.env.ClusterEnvironment

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Closes #1867,

@pujavs pujavs requested a review from yuriyz as a code owner July 25, 2022 10:36
@mo-auto mo-auto mentioned this pull request Jul 25, 2022
Closed
@mo-auto
Copy link
Member

mo-auto commented Jul 25, 2022

Error: Hi @pujavs, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto
Copy link
Member

mo-auto commented Jul 25, 2022

Error: Hi @pujavs, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto mo-auto mentioned this pull request Jul 25, 2022
Closed
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jul 25, 2022
@mo-auto mo-auto mentioned this pull request Jul 25, 2022
Closed
@mo-auto
Copy link
Member

mo-auto commented Jul 25, 2022

Error: Hi @pujavs, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto mo-auto mentioned this pull request Jul 25, 2022
Closed
@mo-auto
Copy link
Member

mo-auto commented Jul 25, 2022

Error: Hi @pujavs, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pujavs pujavs mentioned this pull request Jul 25, 2022
Closed
@yuriyz yuriyz merged commit c996b51 into main Jul 25, 2022
@yuriyz yuriyz deleted the jans-config-api-fixes branch July 25, 2022 10:45
@mo-auto mo-auto mentioned this pull request Aug 30, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

Assignees

@yuriyz yuriyz

Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
3 participants
@pujavs @mo-auto @yuriyz