Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(jans-auth-server): removed builder variable from Token Endpoint #1591 #1938

Merged
merged 1 commit into from
Jul 29, 2022
Merged

refactor(jans-auth-server): removed builder variable from Token Endpoint #1591 #1938

merged 1 commit into from
Jul 29, 2022

Conversation

yuriyzz
Copy link
Contributor

@yuriyzz yuriyzz commented Jul 29, 2022

Prepare

Description

Removed builder variable - we should strive to more isolated/decoupled code.

Target issue

Closes #1591

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests are present
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@yuriyz yuriyz merged commit 9bbfd99 into main Jul 29, 2022
@yuriyz yuriyz deleted the jans-auth-server-1591-5 branch July 29, 2022 10:49
@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality labels Jul 29, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-auth-server Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(jans-auth-server): refactor TokenRestWebServiceImpl
3 participants
@yuriyzz @yuriyz @mo-auto