Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans): added null check to avoid NullPointerException #3077

Merged
merged 1 commit into from
Nov 24, 2022
Merged

fix(jans): added null check to avoid NullPointerException #3077

merged 1 commit into from
Nov 24, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Nov 24, 2022

Prepare

Description

Added null check to resolve two NullPointerException

  1. CustomObjectAttribute NPE while executing User management endpoint - jenkins build
    Error: Caused by: java.lang.NullPointerException at io.jans.orm.model.base.CustomObjectAttribute.getDisplayValue(CustomObjectAttribute.java:92)

  2. LocalizedString while testing OpenID Client functionality
    Error: Caused by: java.lang.NullPointerException at io.jans.orm.model.base.LocalizedString.getLanguageTags(LocalizedString.java:77)

Target issue

closes #3074

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR comp-jans-orm Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Nov 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yuriyz yuriyz merged commit 42d49b2 into main Nov 24, 2022
@yuriyz yuriyz deleted the jans-config--3074 branch November 24, 2022 16:19
This was referenced Dec 1, 2022
Merged
Merged
@mo-auto3 mo-auto3 mentioned this pull request Dec 1, 2022
Merged
This was referenced Jan 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR comp-jans-orm Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans): add null check to avoid NullPointerException
3 participants
@pujavs @yuriyz @mo-auto