Feature: Block authentication flow originating from a web view (mobile app) #3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error: Hi @Milton-Ch, You did not reference an open issue in your PR. I attempted to create an issue for you. |
mo-auto
added
comp-jans-auth-server
|
[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!
|
|
[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed! |
yuriyz
requested review from
devrimyatar,
smansoft,
yuriyz and
yurem
as code owners
yuriyz
approved these changes
Dec 5, 2022
This was referenced Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
Description
feat: block authentication flow originating from a web view (mobile app).
Target issue
closes #3016
Implementation Details
Added a new
validateNotWeviewmethod and also a new configuration parameterblockWebviewAuthorizationEnabled(default is false).The method validation is based on request header, if there is
X-Requested-Withheader then it is a request originated from a web view.Closes #3205,