Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: crypto keys. #3389

Merged
merged 1 commit into from
Dec 22, 2022
Merged

docs: crypto keys. #3389

merged 1 commit into from
Dec 22, 2022

Conversation

mmrraju
Copy link
Contributor

@mmrraju mmrraju commented Dec 22, 2022 •
edited by nynymike
Loading

Prepare

Description

Target issue

#3235

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

shmorri
shmorri approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@shmorri shmorri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@shmorri shmorri merged commit 04336e2 into JanssenProject:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmorri shmorri shmorri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmrraju @shmorri