Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-linux-setup): dummy values for KC db options #8821

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

devrimyatar
Copy link
Contributor

closes #8805

Signed-off-by: Mustafa Baser <mbaser@mail.com>
@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-linux-setup Component affected by issue or PR labels Jun 29, 2024
Copy link

dryrunsecurity bot commented Jun 29, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Server-Side Request Forgery Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
Authn/Authz Analyzer 1 finding
Sensitive Files Analyzer 0 findings
IDOR Analyzer 0 findings
SQL Injection Analyzer 0 findings
Secrets Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The code changes in this pull request focus on the configuration and installation of the Jans SAML (Security Assertion Markup Language) component, specifically its integration with the Keycloak identity provider (IDP). The key changes include updates to the database configuration, hostname settings, and port settings, as well as the addition of observability, proxy header handling, and logging configurations. From an application security perspective, these changes are generally positive as they improve the flexibility, deployment, and monitoring capabilities of the application.

However, there are several areas that require careful review and validation to ensure the overall security of the system. These include the secure storage and management of sensitive credentials (such as database and Keycloak admin credentials), the proper configuration of authentication flows and execution steps, the secure handling of sensitive data, and the verification of the integrity and security of all dependencies. Additionally, the permissions and ownership of directories and files should be reviewed to prevent any unintended access or privilege escalation vulnerabilities.

Files Changed:

  1. jans-linux-setup/jans_setup/templates/jans-saml/keycloak.conf:

    • The database configuration has been updated to use variables instead of hardcoded values.
    • The hostname setting has been changed from %(kc_hostname)s to %(keycloack_hostname)s, potentially fixing a typo.
    • The http-port setting has been updated to use the %(idp_config_http_port)s variable.
    • The configuration includes settings for health checks, metrics collection, proxy headers, and logging, which are important for observability and security monitoring.
  2. jans-linux-setup/jans_setup/setup_app/installers/jans_saml.py:

    • The code sets up various Keycloak-related configurations, such as the admin realm, username, and password, as well as a client, user, and assigned roles for the "jans-api-user".
    • The code configures a custom authentication flow and execution steps within the Keycloak realm.
    • The code creates a user storage provider component within the Keycloak realm.
    • The code generates and uses various sensitive values, such as client secrets, user passwords, and LDAP configuration data.
    • The code downloads and extracts several JAR files and ZIP archives from various sources.
    • The code sets the ownership and permissions of various directories and files.

Powered by DryRun Security

Copy link

sonarcloud bot commented Jun 29, 2024

@yuriyz yuriyz enabled auto-merge (squash) June 29, 2024 10:19
@yuriyz yuriyz merged commit dfbf29e into main Jun 30, 2024
10 checks passed
@yuriyz yuriyz deleted the jans-linux-setup-kc-8805 branch June 30, 2024 13:30
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Former-commit-id: dfbf29e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-linux-setup): Error while installing KC in jans 1.1.3.nighlty
3 participants