Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TinkerPop from 3.7.0 to 3.7.1 [tp-tests][cql-tests] #4199

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

li-boxuan
Copy link
Member


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Jan 2, 2024
@li-boxuan
Copy link
Member Author

I have totally forgotten about this. Seems I have to push a new commit to make the CI run again.

Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
@li-boxuan li-boxuan changed the title Bump TinkerPop from 3.7.0 to 3.7.1 [tp-tests] Bump TinkerPop from 3.7.0 to 3.7.1 [tp-tests][cql-tests] Apr 10, 2024
@li-boxuan li-boxuan added this to the Release v1.0.1 milestone Apr 10, 2024
Copy link
Member

@FlorianHockmann FlorianHockmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be added to the 1.1.0 milestone since its targeting master? The backport PR for the v1.0 can then get the 1.0.1 milestone.

edit: And I think we also need to update the version for the docs here: https://github.com/JanusGraph/janusgraph/blob/master/mkdocs.yml#L99

@li-boxuan
Copy link
Member Author

@FlorianHockmann you're right, thanks! Will do a CTR (is that still allowed? if not, I'll create a new PR) to fix the doc, so that we don't have to wait for another full build and waste CI cycles

@li-boxuan
Copy link
Member Author

You can tell how much I have already forgotten about JanusGraph development cycle :)

@li-boxuan li-boxuan merged commit c46a841 into JanusGraph:master Apr 11, 2024
119 checks passed
@li-boxuan li-boxuan deleted the dependency/tp-3.7.1 branch April 11, 2024 03:47
@janusgraph-automations
Copy link

💚 All backports created successfully

Status Branch Result
v1.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.0 cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants