-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump TinkerPop from 3.7.0 to 3.7.1 [tp-tests][cql-tests] #4199
Conversation
4abbcdf
to
bd93346
Compare
I have totally forgotten about this. Seems I have to push a new commit to make the CI run again. |
Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
bd93346
to
451e09c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be added to the 1.1.0
milestone since its targeting master
? The backport PR for the v1.0
can then get the 1.0.1
milestone.
edit: And I think we also need to update the version for the docs here: https://github.com/JanusGraph/janusgraph/blob/master/mkdocs.yml#L99
@FlorianHockmann you're right, thanks! Will do a CTR (is that still allowed? if not, I'll create a new PR) to fix the doc, so that we don't have to wait for another full build and waste CI cycles |
You can tell how much I have already forgotten about JanusGraph development cycle :) |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master
)?For code changes:
For documentation related changes: