Improve readability of testReadMarkerCompatibility #4759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please sign your commit to pass DCO check? https://github.com/JanusGraph/janusgraph/pull/4759/checks?check_run_id=36459918966 |
porunov
reviewed
Feb 1, 2025
There was a problem hiding this comment.
Thank you for clean-up! You should also remove unused imports as lint suggested:
Error: /home/runner/work/janusgraph/janusgraph/janusgraph-backend-testutils/src/main/java/org/janusgraph/diskstorage/log/LogTest.java:43:15: Unused import - org.junit.jupiter.api.Assertions.fail. [UnusedImports]
pedrinhoeu
changed the title
pedrinhoeu
force-pushed
the
patch-3
branch
2 times, most recently
from
2295dda to
ec0f56e
Compare
li-boxuan
changed the title
Improves the readability of the test. Replaces manual exception handling with the testing framework's built-in features (e.g., assertThrows), improving readability, maintainability, and debugging efficiency. Signed-off-by: pedro_Simoes <pelusimoes3@gmail.com> Signed-off-by: pedro_Simoes <115429183+pedrinhoeu@users.noreply.github.com>
Signed-off-by: pedro_Simoes <pelusimoes3@gmail.com> Signed-off-by: pedro_Simoes <115429183+pedrinhoeu@users.noreply.github.com>
Signed-off-by: pedro_Simoes <115429183+pedrinhoeu@users.noreply.github.com>
li-boxuan
approved these changes
Feb 16, 2025
porunov
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the readability of the test. Replaces manual exception handling with the testing framework's built-in features (e.g., assertThrows), improving readability, maintainability, and debugging efficiency.
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master)?