[java-onboarding-week-1] haon.lee(이민성) 과제 제출합니다.#2
Open
msung99 wants to merge 7 commits intoJapring-Study:haon/java-onboarding-week-1from
Open
[java-onboarding-week-1] haon.lee(이민성) 과제 제출합니다.#2msung99 wants to merge 7 commits intoJapring-Study:haon/java-onboarding-week-1from
msung99 wants to merge 7 commits intoJapring-Study:haon/java-onboarding-week-1from
Conversation
alreadysons
reviewed
Sep 3, 2024
|
|
||
| // 포비의 결과 리스트를 구한다. | ||
| List<Integer> pobiResultList = List.of(getSumValue(pobiLeftPage), getSumValue(pobiRightPage), | ||
| getMultiplyValue(pobiLeftPage), getMultiplyValue(pobiRightPage)); |
There was a problem hiding this comment.
left,right 페이지의 sum,multiply값을 합쳐서 리스트를 통해 MAX값을 구하는 점이 인상깊었습니다!
dayaelee
reviewed
Sep 3, 2024
Member
dayaelee
left a comment
dayaelee
left a comment
There was a problem hiding this comment.
고려해야할 예외 케이스를 세세하게 고려하여 코드를 잘 작성하신 것 같습니다 !
alreadysons
reviewed
Sep 3, 2024
| Stack<Character> stack = new Stack<>(); | ||
|
|
||
| for (char c : cryptogram.toCharArray()) { | ||
| if (!stack.isEmpty() && stack.peek() == c) { |
alreadysons
reviewed
Sep 3, 2024
| Set<String> userFriends = new HashSet<>(); | ||
|
|
||
| // 사용자와 친구인 사람들 기록 | ||
| for (List<String> pair : friends) { |
dayaelee
reviewed
Sep 3, 2024
| return answer; | ||
| StringBuilder result = new StringBuilder(); | ||
|
|
||
| for (char c : word.toCharArray()) { |
dayaelee
reviewed
Sep 3, 2024
| List<Integer> result = new ArrayList<>(); | ||
|
|
||
| // 각 화폐 단위에 대해 몫을 구하고 나머지를 계산 | ||
| for (int unit : units) { |
dayaelee
reviewed
Sep 3, 2024
| String nickname2 = forms.get(j).get(1); | ||
|
|
||
| if (hasCommonSubstring(nickname1, nickname2)) { | ||
| duplicateEmails.add(email1); |
dayaelee
reviewed
Sep 3, 2024
| return a.compareTo(b); | ||
| }); | ||
|
|
||
| // 최대 5명까지만 추천 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.