Support for class names as keywords

[paintparty]

Thanks for making Stylefy!
Really great project.

In order to maintain feature parity with reagent, would it be possible to support the following syntax in the second (html attributes) argument to use-style?

(use-style
    {:color "red"}               
    {:class :some-class})

And also a vector of keywords:

(use-style
    {:color "red"}               
    {:class [:some-class :some-other-class]})

[Jarzka]

Glad you find stylefy useful.

I gave an answer to this, but I had to re-check it and it was partially incorrect, so I deleted it. Here is the new answer:

Yes, if this syntax works in Hiccup & Reagent, it should work in stylefy when you call use-style. Now it does not, and here is why:

Originally, the second param of use-style, meaning the option map, only accepted a map with a special keyword of ::with-classes. Later, I changed the implementation of the second param so that the whole map contains HTML attributes. However, since some people had already used ::with-classes, I had to implement support for it. Thus, how stylefy handles :class is that it combines both :class and ::with-classes. In this combination, the richer syntax support of Reagent seems to be lost.

I think, at this point, it would be time to deprecate ::with-classes once and for all, i.e. remove it completely and log a warning if people use it. The feature has been marked as deprecated since version 1.3.0 (2018) and it can be easily replaced with :class. The contents of :class could be used as it is and all Reagent syntax would be supported.

By the way, the first argument of use-style also accepts ::with-classes. This is still valid, I'm only talking about the second parameter, the option map.

[Jarzka]

I forgot that ::with-styles is still valid in style map (it accepts a vector of strings), so we have to combine it with :class anyway. But maybe we can still add manual support for passing keywords and vector of keywords to :class. I'm planning on adding this support in the next version.

[paintparty]

Thanks!

[Jarzka]

This feature is now implemented in the latest release: 2.1.1

[paintparty]

Thanks for the quick turnaround!!

…

On Sat, May 30, 2020 at 2:19 AM Jari Hanhela ***@***.***> wrote: This feature is now implemented in the latest release candidate version: 2.0.0-rc.2 It should be stable, but I do not encourage you to use it in production just yet. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#44 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIOESV4HXDMP2BKZX4UJT3RUDFRDANCNFSM4NJZBYDQ> .