-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: remove delay when clearing all notifications #342
Conversation
f366843
to
c7a1b8c
Compare
I'm not a fan of the delay either ideally it should be MUCH lower but this is something you have to do to prevent crashes in AGS. Notice the For some users this number has to be even higher. If we want to remove it, we can add an option to let the user define the delay amount and add a warning below the settings that "Setting this value too low may crash AGS". |
Looks like this PR still needs some work. I will try to add in the option by tomorrow |
c7a1b8c
to
c0d3bfd
Compare
Updated the setting widget to include the delay with the initial value as |
That's for the wonderful contributions! ❤️ |
When having 50+ notifications, clicking the clear all button takes some time before it does the job.
This was because we were adding a delay with settimeout of 100 ms .
This makes the clearall instant which is a better UX similar to other implementations like in
swaync