fix: dont hardcode file manager and make use of $TERM #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jas-SinghFSU check this . I think this can be merged |
rubiin
changed the title
Co-authored-by: Jas Singh <jaskiratpal.singh@outlook.com>
Co-authored-by: Jas Singh <jaskiratpal.singh@outlook.com>
Co-authored-by: Jas Singh <jaskiratpal.singh@outlook.com>
Co-authored-by: Jas Singh <jaskiratpal.singh@outlook.com>
|
@Jas-SinghFSU fixed |
Jas-SinghFSU
approved these changes
Oct 26, 2024
ashebanow
added a commit
to ashebanow/ags
that referenced
this pull request
Dec 10, 2024
* feat: make executables dynamic * feat: make executables dynamic * Update modules/menus/dashboard/stats/index.ts Co-authored-by: Jas Singh <jaskiratpal.singh@outlook.com> * Update widget/settings/pages/config/general/index.ts Co-authored-by: Jas Singh <jaskiratpal.singh@outlook.com> * Update options.ts Co-authored-by: Jas Singh <jaskiratpal.singh@outlook.com> * Update modules/menus/dashboard/stats/index.ts Co-authored-by: Jas Singh <jaskiratpal.singh@outlook.com> * fix: var to term --------- Co-authored-by: Jas Singh <jaskiratpal.singh@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, user can use any file manager they have setup.
This also removes terminal and uses the one setup on $TERM varibale. The original PR contains a mistake as TERM env is used instead of TERMINAL
https://www.ibm.com/docs/en/informix-servers/14.10?topic=products-term-environment-variable-unix
https://bash.cyberciti.biz/guide/$TERM_variable
closes #156