Fix: Matugen Global themes #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
with the addition of
--dryflag to the matugen command in the past update, Matugen only generates themes for Hyprpanel.If the user has other configs for other applications, the necessary changes to the colour scheme wont be made for them. The user can run the matugen command again to rectify this. But this is not ideal.
With the changes i have made, if the user run
it will change the theme for hyprpanel as well as any other applications specified in matugen config file. Additionally changing the wallpaper from the setting panel will now also update the colorscheme on not just hyprpanel but any other apps specified in the matugen config file.
Documentation update
In the matugen section of the documentation, users must me informed to use the below command or the settings panel to change their background instead of using
matugen image.Additionally it is advised that the user use matugen to only generate colourscheme and not set wallpaper.