Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache builtins #1505

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Cache builtins #1505

wants to merge 6 commits into from

Conversation

Thamirawaran
Copy link
Collaborator

@Thamirawaran Thamirawaran commented Jan 1, 2025 •
edited
Loading

Description

  1. Caching Builtins.pyi file
  2. Test case added

@Thamirawaran Thamirawaran changed the title Test cache ast Test cache builtins Jan 1, 2025
@Thamirawaran Thamirawaran self-assigned this Jan 1, 2025
@Thamirawaran Thamirawaran changed the title Test cache builtins Cache builtins Jan 7, 2025
ThakeeNathees
ThakeeNathees requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@ThakeeNathees ThakeeNathees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there are some nitpicks i've left, @Thamirawaran can you have a look

jac/jaclang/compiler/passes/main/import_pass.py Outdated Show resolved Hide resolved
jac/jaclang/compiler/passes/main/import_pass.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThakeeNathees ThakeeNathees ThakeeNathees requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Thamirawaran Thamirawaran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thamirawaran @ThakeeNathees