[Lark-PR-3] SpecialVarRef removed and merged with Name #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThakeeNathees
changed the title
ThakeeNathees
force-pushed
the
thakee-lark-3
branch
from
8643cb5 to
a0831cf
Compare
ThakeeNathees
force-pushed
the
thakee-lark-3
branch
2 times, most recently
from
c59710d to
b3f1512
Compare
mgtm98
reviewed
Jan 31, 2025
mgtm98
reviewed
Jan 31, 2025
| @@ -160,13 +160,6 @@ def enter_index_slice(self, node: ast.IndexSlice) -> None: | |||
| is_range: bool, | |||
| """ | |||
|
|
|||
| def enter_special_var_ref(self, node: ast.SpecialVarRef) -> None: | |||
There was a problem hiding this comment.
Can we have old SpecialVarRef to have a parent of atom trailer?
mgtm98
reviewed
Jan 31, 2025
There was a problem hiding this comment.
I checked these changes. There is a comment I added. @marsninja please check it
ThakeeNathees
force-pushed
the
thakee-lark-3
branch
from
b3f1512 to
99e9cab
Compare
Thamirawaran
requested changes
Feb 7, 2025
| // | ||
| // module: STRING? toplevel_stmt* | ||
| // | ||
| module: (toplevel_stmt (tl_stmt_with_doc | toplevel_stmt)*)? |
There was a problem hiding this comment.
module: STRING? (STRING? toplevel_stmt)*
It could replace
module: (toplevel_stmt (tl_stmt_with_doc | toplevel_stmt)*)?
| STRING (tl_stmt_with_doc | toplevel_stmt)*
tl_stmt_with_doc: STRING toplevel_stmt
So that we can get rid of tl_stmt_with_doc node in parser
If you want to keep that node
we can go with
module: STRING? tl_stmt_with_doc*
tl_stmt_with_doc: (STRING? toplevel_stmt)
There was a problem hiding this comment.
We can't do that cause there is ambiguity since we have STRING? STRING? and the lark reduce doesn't know if the first string should be module dostring or class docstring,
There was a problem hiding this comment.
Yeah
Let's use this
module: STRING? tl_stmt_with_doc
tl_stmt_with_doc: (STRING? toplevel_stmt)*
I hope it fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on : #1523
SpecialVarRefwas removed and merged withNameIn terms of function and use, there are almost no difference between name and special var ref (almost every where the logic is the same and copied), now they're merged.named_refrenamed tonamein lark rule.