Updates for External Files, Menus, and custom fields #2
Conversation
There was a problem hiding this comment.
Thanks for your pull request!
Code generally looks good.
I left a few questions and comments.
Some general orders of business for contributing:
- Could you sign the Apereo ICLA? https://www.apereo.org/licensing/agreements
- Could you report this as a feature request on this portlet's issue tracker? https://issues.jasig.org/browse/IQ
- Could you include a summary of the change in the pull request?
- optional Screenshots of changes that affect the appearance of the portlet are helpful
- optional This looks like a significant change, the uPortal dev group may be interested https://groups.google.com/a/apereo.org/forum/#!forum/uportal-dev
| JOptionPane.showMessageDialog(this.jtable.getParent(), | ||
| "Invalid Number"); | ||
| Utilities.MessageDialog(this.jtable.getParent(), "Invalid Number"); | ||
| //JOptionPane.showMessageDialog(this.jtable.getParent(), "Invalid Number"); |
There was a problem hiding this comment.
could the commented out JOptionPane thoughout the code be removed?
pom.xml
Outdated
| @@ -28,9 +28,10 @@ | |||
| <version>40</version> | |||
| </parent> | |||
|
|
|||
| <!-- updated ztesler, 04-2016 --> | |||
There was a problem hiding this comment.
git automatically tracks which user most recently edited a given line of code.
pom.xml
Outdated
| <groupId>org.apereo.application</groupId> | ||
| <artifactId>ImageQuiz</artifactId> | ||
| <version>1.0-SNAPSHOT</version> | ||
| <version>2.0</version> |
There was a problem hiding this comment.
jumping to version 2 before version 1 is tagged?
There was a problem hiding this comment.
Following semantic versioning, this is likely 1.0.1 (if only patches) or 1.1.0 if there are new features. Since it looks compatible with previous versions, it really does not look like a 2.0 release.
Thanks Christian for the review!
There was a problem hiding this comment.
Since there's been no 1.0.0 release, I think the <version> shouldn't increment at all. Start observing Semantic Versioning after 1.0.0. Before then it's just a wild west snapshot.
|
I verify a name matching @givemeahigh5 's name appears among the names of people who have signed ICLAs. |
|
I grabbed the branch behind this pull request, built and ran locally. The resulting EDIT: @BKKirchoff kindly lent me some quiz content for testing. I successfully ran the |
|
Additional assets, including a database and graphics, are needed locally to run the app -- without them nothing shows up after the login screen. There are multiple versions (i.e. plants, herpetology) managed separately and not included here. @apetro it sounds like maybe you lacked these. I can run both Jasig/master and my local branch without incident, though the versioning and comment issues above still need to be addressed. |
Patches to better serve multi-OS delivery and app customization: