Search for all issues instead of open, closed.

README.md

@@ -87,12 +87,12 @@ steps:
       assignees: JasonEtco, octocat
       milestone: 1
       update_existing: true
-      search_existing: open, closed
+      search_existing: all
 ```
 
-The `assignees` and `milestone` speak for themselves. 
-The `update_existing` param can be passed and set to `true` when you want to update an open issue with the **exact same title** when it exists. 
-The `search_existing` param lets you specify whether to search open and/or closed existing issues for duplicates (default is `open`).
+* The `assignees` and `milestone` speak for themselves.
+* The `update_existing` param can be passed and set to `true` when you want to update an open issue with the **exact same title** when it exists.
+* The `search_existing` param lets you specify whether to search `open`, `closed`, or `all` existing issues for duplicates (default is `open`).
 
 ### Outputs
 

src/action.ts

@@ -10,7 +10,7 @@ export async function createAnIssue (tools: Toolkit) {
   const template = tools.inputs.filename || '.github/ISSUE_TEMPLATE.md'
   const assignees = tools.inputs.assignees
   const updateExisting = Boolean(tools.inputs.update_existing)
-  const searchExistingTypes = (tools.inputs.search_existing || 'open').split(',').map(s => s.trim());
+  const searchExistingType = tools.inputs.search_existing || 'open'
   const env = nunjucks.configure({ autoescape: false })
   env.addFilter('date', dateFilter)
 
@@ -40,16 +40,11 @@ export async function createAnIssue (tools: Toolkit) {
     tools.log.info(`Fetching issues with title "${templated.title}"`)
     try {
 
-      // Fetch existing issues that match title
-      const issues = (await Promise.all(searchExistingTypes.map(s => {
-        return tools.github.search.issuesAndPullRequests({
-          q: `is:${s} is:issue repo:${process.env.GITHUB_REPOSITORY} in:title ${templated.title}`
-        }).then(existingIssues => {
-          return existingIssues.data.items
-        })})
-      )).flat()
+      const existingIssues = await tools.github.search.issuesAndPullRequests({
+        q: `is:${searchExistingType} is:issue repo:${process.env.GITHUB_REPOSITORY} in:title ${templated.title}`
+      })
 
-      existingIssue = issues.find(issue => issue.title === templated.title)
+      existingIssue = existingIssues.data.items.find(issue => issue.title === templated.title)
 
     } catch (err) {
       tools.exit.failure(err)

tests/index.test.ts

@@ -186,21 +186,7 @@ describe('create-an-issue', () => {
         var q = parsedQuery['q']
         if (typeof(q) === 'string') {
           var args = q.split(' ')
-          return args.includes('is:open') && args.includes('is:issue')
-        } else {
-          return false
-        }
-      })
-      .reply(200, {
-        items: []
-      })
-      // matching closed issue
-      .get(/\/search\/issues.*/)
-      .query(parsedQuery => {
-        var q = parsedQuery['q']
-        if (typeof(q) === 'string') {
-          var args = q.split(' ')
-          return args.includes('is:closed') && args.includes('is:issue')
+          return args.includes('is:all') && args.includes('is:issue')
         } else {
           return false
         }
@@ -211,12 +197,12 @@ describe('create-an-issue', () => {
       .patch(/\/repos\/.*\/.*\/issues\/.*/).reply(200, {})
 
     process.env.INPUT_UPDATE_EXISTING = 'true'
-    process.env.INPUT_SEARCH_EXISTING = 'open, closed'
+    process.env.INPUT_SEARCH_EXISTING = 'all'
 
     await createAnIssue(tools)
     expect(params).toMatchSnapshot()
     expect(tools.exit.success).toHaveBeenCalled()
-  })  
+  })
 
   it('exits when updating an issue fails', async () => {
     nock.cleanAll()