Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on MacOS #118

Open
Blaisorblade opened this issue Apr 9, 2022 · 2 comments
Open

Tests fail on MacOS #118

Blaisorblade opened this issue Apr 9, 2022 · 2 comments

Comments

@Blaisorblade
Copy link

Very low priority — I don't know that this matters, but I noticed in coq/coq#15880.

Many tests fail with bash syntax errors. Maybe because the run-example-XX scripts use /bin/bash as shebang instead of /usr/bin/env bash — but after fixing this in run-example-00.sh, tests fail with further errors.

Original error

Failing test logs:
example_00_result.log:
$ . /Users/pgiarrusso1/git-bedrock/coq/_build_ci/coq_tools/examples/disable-parallel-make.sh
$$ export MAKEFLAGS=
$$ MAKEFLAGS=
./run-example-00.sh: line 125: unexpected EOF while looking for matching `"'
./run-example-00.sh: line 129: syntax error: unexpected end of file
JasonGross added a commit that referenced this issue Apr 9, 2022
@JasonGross
Copy link
Owner

This particular error is a bug that was fixed ~15 years ago in Bash 4.0, cf https://unix.stackexchange.com/a/783611/45323, although there are further issues (such as with /tmp)

@JasonGross
Copy link
Owner

I don't have the time to fix these issues currently, but I'd be happy with a PR that fixes them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants