Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$network.request logging #258

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

$network.request logging #258

wants to merge 3 commits into from

Conversation

gliechtenstein
Copy link
Contributor

Code derived from @jashot7's code at Jasonette/documentation#78 (comment)

The debugging feature kicks in when options.debug is set to true. For example:

{
  "type": "$network.request",
  "options": {
    "url": "...",
    "debug": "true"
  },
  "success": {
    "type": "$render"
  }
}

@clsource
Copy link
Contributor

Line 161

Could have a potential crash if the method object is nil. I recommend having a default value.

@gliechtenstein
Copy link
Contributor Author

@clsource nice catch! just fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants