Single HiLo id generator per document store

[oakio]

No description provided.

[mdissel]

Resulting in unique ID's for each record in every table? If yes, nice enhancement 👍

[jeremydmiller]

@oakio I'd be worried about contention if you do this. Why is this valuable?

[oakio]

The main reason is if I want to merge two tables into one, I will not have conflicts by id

[jeremydmiller]

@oakio Okay, but this one is "I take pull requests";) Some kind of way to declare that the Hilo sequence is shared?

[mysticmind]

The main reason is if I want to merge two tables into one, I will not have conflicts by id

I would argue that this is not a typical use case Marten users would encounter on a regular basis. So going ahead and closing this.

[mysticmind]

Follow on note, please have a look at https://dba.stackexchange.com/questions/193788/what-can-go-wrong-using-the-same-sequence-across-multiple-tables-in-postgres. I would veto this feature in Marten.

[mdissel]

@mysticmind Would you accept a pull request that changes the current HiLoSequence behaviour to make it possible to override the entitiyname? by default the enitityname equals the doctype, but it can be overridden so you can have a sequence that is used by multiple tables.

[mdissel]

@oakio have you already started working on this request?

[oakio]

@mdissel no

[mdissel]

Still relevant for you?

[mdissel]

At first sight it seems that this is necessary:

• extend HiLoSettings with an optional SequenceName property
• use SequenceName if set in this method

  marten/src/Marten/Schema/Identity/Sequences/SequenceFactory.cs

  Line 61 in c8016cd

  return new HiloSequence(_tenant, _options, documentType.Name, settings);

  
  and

  marten/src/Marten/Schema/Identity/Sequences/SequenceFactory.cs

  Line 68 in c8016cd

  type => new HiloSequence(_tenant, _options, documentType.Name, settings));

[mysticmind]

@mdissel yes, PRs are welcome :-) I notice that you have sent a PR, will review the same.