ViewProjection - Only Delete view if it exists #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticmind
approved these changes
Sep 5, 2019
There was a problem hiding this comment.
@ericgreenmix Looks fine to me. Could you please add a unit test for this fix?
oskardudycz
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Same comment as @mysticmind - I'm fine with merging after adding some unit test(s) for this case 👍
|
Done |
|
@ericgreenmix thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in my last ViewProjection changes that would attempt to delete a view if it was
null. This fixes that issue by checking if the view exists before calling delete.